[HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] Smart scanning header is broken #29626

lanitochka17 · 2023-10-14T19:16:32Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.84.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Click the + action button and request money
Select Scan
Upload receipt as part of the Scan flow and complete the process
Open the uploaded receipt

Expected Result:

Smart scanning header is visible

Actual Result:

Smart scanning header is broken

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6237271_1697310012718.Recording__4999.mp4

MacOS: Desktop

View all open jobs on GitHub

The text was updated successfully, but these errors were encountered:

melvin-bot · 2023-10-14T19:16:37Z

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-10-14T19:16:39Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

OSBotify · 2023-10-14T19:18:06Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-10-14T19:18:09Z

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

abdel-h66 · 2023-10-14T19:33:40Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split details receipt scan header is broken

What is the root cause of that problem?

In the SplitDetailsPage.js <MoneyRequestHeaderStatusBar is called without any arguments

{isScanning && <MoneyRequestHeaderStatusBar />}

What changes do you think we should make in order to solve the problem?

Update the SplitDetailsPage.js to call with the required arguments <MoneyRequestHeaderStatusBar /> similar to what's being done in MoneyRequestHeader.js

                    {isScanning && <MoneyRequestHeaderStatusBar 
                     title={translate('iou.receiptStatusTitle')}
                     description={translate('iou.receiptStatusText')}
                     shouldShowBorderBottom
                    />}

What alternative solutions did you explore? (Optional)

N/A

shubham1206agra · 2023-10-15T06:06:47Z

Offending PR #29201

mountiny · 2023-10-15T21:05:27Z

cc @grgia

mountiny · 2023-10-16T12:47:16Z

fixed

mountiny · 2023-10-16T12:47:39Z

@rushatgabhane will get $500 for internal review

joekaufmanexpensify · 2023-10-16T14:49:34Z

Sounds good! We'll issue payment after the 7 day waiting period.

melvin-bot · 2023-10-16T21:32:10Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
[@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@rushatgabhane] Determine if we should create a regression test for this bug.
[@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:56:42Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] - Only show Pending Banner for ECard Transactions #29659

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@rushatgabhane does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:56:44Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
[@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@rushatgabhane] Determine if we should create a regression test for this bug.
[@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-17T23:02:13Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] - Only show Pending Banner for ECard Transactions #29659

If no regressions arise, payment will be issued on 2023-10-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@rushatgabhane does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-17T23:02:14Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR: [Wave 8 - ECard Transactions] Update Money Request View Fields to support Ecard transactions #29201
[@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [Wave 8 - ECard Transactions] Update Money Request View Fields to support Ecard transactions #29201 (comment)
[@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@rushatgabhane] Determine if we should create a regression test for this bug.
[@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/333020

joekaufmanexpensify · 2023-10-23T13:27:32Z

I see @rushatgabhane was actually already paid for this one on the PR.

joekaufmanexpensify · 2023-10-23T13:28:31Z

@rushatgabhane please complete your portion of the BZ checklist when you have a sec, and then we'll be all set to close this out!

joekaufmanexpensify · 2023-10-24T20:20:27Z

Pending completion of checklist

joekaufmanexpensify · 2023-10-25T14:10:28Z

Bumped in Slack

joekaufmanexpensify · 2023-10-26T14:28:40Z

Still pending completion

melvin-bot · 2023-10-30T12:53:42Z

@rushatgabhane, @thienlnam, @grgia, @joekaufmanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

joekaufmanexpensify · 2023-10-30T13:49:20Z

Not overdue. @rushatgabhane is anything needed for BZ checklist here?

joekaufmanexpensify · 2023-10-31T17:30:56Z

Bumped in Slack

joekaufmanexpensify · 2023-11-01T13:39:05Z

Still pending input

rushatgabhane · 2023-11-02T17:24:21Z

The PR that introduced the bug has been identified. Link to the PR: [Wave 8 - ECard Transactions] Update Money Request View Fields to support Ecard transactions #29201
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [Wave 8 - ECard Transactions] Update Money Request View Fields to support Ecard transactions #29201 (comment)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
Determine if we should create a regression test for this bug. Sure
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again
1. Create a money request -> upload receipt -> click on Money Request Preview
2. Verify "Scanning" Banner is shown

rushatgabhane · 2023-11-02T17:28:25Z

we can close the issue

joekaufmanexpensify · 2023-11-03T13:52:39Z

Sweet, TY! BZ checklist is all set. Payment was already issued on the PR, so closing as this one is good to go.

lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 14, 2023

melvin-bot bot assigned joekaufmanexpensify Oct 14, 2023

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 14, 2023

OSBotify mentioned this issue Oct 14, 2023

Deploy Checklist: New Expensify 2023-10-13 #29585

Closed

97 tasks

melvin-bot bot assigned thienlnam Oct 14, 2023

melvin-bot bot mentioned this issue Oct 15, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [ECard Transactions] Update MoneyRequestView UI #28835

Closed

grgia self-assigned this Oct 15, 2023

grgia mentioned this issue Oct 16, 2023

[CP Staging] - Only show Pending Banner for ECard Transactions #29659

Merged

65 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Oct 16, 2023

mountiny assigned rushatgabhane Oct 16, 2023

mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Oct 16, 2023

mountiny mentioned this issue Oct 16, 2023

[HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] Desktop - When uploading a receipt via the request money flow, it shows as Pending #29625

Closed

6 tasks

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023

melvin-bot bot changed the title ~~[HOLD for payment 2023-10-23] Smart scanning header is broken~~ [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] Smart scanning header is broken Oct 16, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 17, 2023

melvin-bot bot changed the title ~~[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] Smart scanning header is broken~~ [HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] Smart scanning header is broken Oct 17, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Daily KSv2 labels Oct 23, 2023

melvin-bot bot added the Overdue label Oct 30, 2023

melvin-bot bot removed the Overdue label Oct 30, 2023

joekaufmanexpensify closed this as completed Nov 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] Smart scanning header is broken #29626

[HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] Smart scanning header is broken #29626

lanitochka17 commented Oct 14, 2023 •

edited

Loading

melvin-bot bot commented Oct 14, 2023

melvin-bot bot commented Oct 14, 2023

OSBotify commented Oct 14, 2023

melvin-bot bot commented Oct 14, 2023

abdel-h66 commented Oct 14, 2023

shubham1206agra commented Oct 15, 2023

mountiny commented Oct 15, 2023

mountiny commented Oct 16, 2023

mountiny commented Oct 16, 2023

joekaufmanexpensify commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 17, 2023 •

edited by joekaufmanexpensify

Loading

melvin-bot bot commented Oct 17, 2023 •

edited by joekaufmanexpensify

Loading

joekaufmanexpensify commented Oct 23, 2023

joekaufmanexpensify commented Oct 23, 2023

joekaufmanexpensify commented Oct 24, 2023

joekaufmanexpensify commented Oct 25, 2023

joekaufmanexpensify commented Oct 26, 2023

melvin-bot bot commented Oct 30, 2023

joekaufmanexpensify commented Oct 30, 2023

joekaufmanexpensify commented Oct 31, 2023

joekaufmanexpensify commented Nov 1, 2023

rushatgabhane commented Nov 2, 2023 •

edited

Loading

rushatgabhane commented Nov 2, 2023

joekaufmanexpensify commented Nov 3, 2023

[HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] Smart scanning header is broken #29626

[HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] Smart scanning header is broken #29626

Comments

lanitochka17 commented Oct 14, 2023 • edited Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Oct 14, 2023

melvin-bot bot commented Oct 14, 2023

Bug0 Triage Checklist (Main S/O)

OSBotify commented Oct 14, 2023

melvin-bot bot commented Oct 14, 2023

abdel-h66 commented Oct 14, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

shubham1206agra commented Oct 15, 2023

mountiny commented Oct 15, 2023

mountiny commented Oct 16, 2023

mountiny commented Oct 16, 2023

joekaufmanexpensify commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 17, 2023 • edited by joekaufmanexpensify Loading

melvin-bot bot commented Oct 17, 2023 • edited by joekaufmanexpensify Loading

joekaufmanexpensify commented Oct 23, 2023

joekaufmanexpensify commented Oct 23, 2023

joekaufmanexpensify commented Oct 24, 2023

joekaufmanexpensify commented Oct 25, 2023

joekaufmanexpensify commented Oct 26, 2023

melvin-bot bot commented Oct 30, 2023

joekaufmanexpensify commented Oct 30, 2023

joekaufmanexpensify commented Oct 31, 2023

joekaufmanexpensify commented Nov 1, 2023

rushatgabhane commented Nov 2, 2023 • edited Loading

rushatgabhane commented Nov 2, 2023

joekaufmanexpensify commented Nov 3, 2023

lanitochka17 commented Oct 14, 2023 •

edited

Loading

melvin-bot bot commented Oct 17, 2023 •

edited by joekaufmanexpensify

Loading

melvin-bot bot commented Oct 17, 2023 •

edited by joekaufmanexpensify

Loading

rushatgabhane commented Nov 2, 2023 •

edited

Loading