Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Sum is disappeared after pay elsewhere in row ’Total” #29627

Closed
1 of 6 tasks
lanitochka17 opened this issue Oct 14, 2023 · 7 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 14, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.84-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Issue found when executing PR #29544

Action Performed:

  1. Launch App
  2. Tap on FAB > request money/ or go to chat and request money
  3. Create a request in this case $99
  4. As the payer, click Pay elsewhere to settle up

Expected Result:

Sum $99 should be displayed in row "Total"

Actual Result:

Sum is disappeared after pay elsewhere in a row ’Total”

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native

Bug6237285_1697310826439!android

Bug6237285_1697310826445.android.mp4
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 14, 2023

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 14, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 14, 2023

Current assignee @puneetlath is eligible for the Engineering assigner, not assigning anyone new.

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Oct 14, 2023

Most likely this is a regression of this ticket #27660

Proposal

Please re-state the problem that we are trying to solve in this issue.

The sum is disappeared after pay elsewhere in row ’Total”

What is the root cause of that problem?

The reason is most likely that since we are passing flex : 1 to the text, looks like it breaks styles on android

What changes do you think we should make in order to solve the problem?

We can remove ...spacing.flex1 from this styles

https://github.com/ZhenjaHorbach/App/blob/b5a40eee69a2f72749101f6cf8e9b2149cc62de1/src/styles/styles.js#L3353-L3361

What alternative solutions did you explore? (Optional)

We can remove this style only for android
But after testing it seems unnecessary as this does not affect anything for other platforms

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 15, 2023
@mountiny
Copy link
Contributor

I believe this should be resolved in 84-1

image

@mountiny
Copy link
Contributor

Resolved so we can close this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants