-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Context menu popup is not dismissed when opening Sign In Model in Incognito mode #29830
Comments
Triggered auto assignment to @laurenreidexpensify ( |
Job added to Upwork: https://www.upwork.com/jobs/~015958dd4a7d354810 |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Context menu popup is not dismissed when opening Sign In Model in Incognito mode What is the root cause of that problem?since the sign in screen is a modal What changes do you think we should make in order to solve the problem?I think we should update the menu and add
App/src/components/ThreeDotsMenu/index.js Lines 66 to 79 in 0cfbec0
What alternative solutions did you explore? (Optional)NA |
ProposalPlease re-state the problem that we are trying to solve in this issue.When an anonymous user is signed in and uses the three dot menu to select a video conferencing option, the sign in modal is shown but the three dot menu is not dismissed. What is the root of the issueWhen the menu item is selected, it triggers the checkIfActionIsAllowed function which interrupts the flow of the logic and redirects the user to the sign in modal. Since the logic of the menu items' selection never gets to the part where it dismisses the popover, the popover is left open. What changes do you think we should make in order to solve the problem?There is an existing pattern to handle this issue. On the floating action button, the menu items' onSelected callback uses the interceptAnonymousUsers to handle this logic inside of the component. We could use this pattern to hide the popover before the redirect occurs. What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.When an anonymous user tries click on any of the items on the Three dot menu, it redirects and open the sign in modal without closing the the popover opened by the three dot menu, thereby blocking the sign in modal What is the root cause of that problem?The cause of the issue is that when any of the item in the popover menu is clicked, it's intercepted by a What changes do you think we should make in order to solve the problem?By updating the What alternative solutions did you explore? (Optional)N/A |
📣 @olalekanteeblaze! 📣
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
ProposalPlease re-state the problem that we are trying to solve in this issue.in case of anonymous user, three dots menu doesnt gets closed when you select an item What is the root cause of that problem?The root cause is that the code is preventing the menu item callback from executing when the popover item is clicked due to a condition at this location: App/src/components/MenuItem.js Line 143 in f0d2d08
Popover closed for anonymous user is not implemented What changes do you think we should make in order to solve the problem?Implement a utility method that handles a click/tap event anywhere on the page where it runs a callback for anonymous users only, allowing us to pass the close popover method. What alternative solutions did you explore? (Optional)N/A |
Should be fixed by #29653 |
@narefyev91 do you agree ^^ |
@laurenreidexpensify ops mixed up with other issue which was also related to menu #28324 |
Tested on latest main not repro: Screen.Recording.2023-10-18.at.12.28.40.mov |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.3.85.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @tranvantoan-qn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697565108183509
Action Performed:
. Go to Incognito mode or log out of any account
2. Follow this public room's link: https://staging.new.expensify.com/r/5593084223054221
3. Click the Three Dots icon in the top-right corner of the page.
4. Select either "Pin," "Zoom," or "Google Meet" from the menu.
5. Observe that: the context menu keeps opening and overlays the Sign-up Modal.
Expected Result:
The context menu popup should close after selecting any option. So the users can use Sign-up Modal
Actual Result:
The context menu keeps opening and overlays the Sign-up Modal
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Android: Native
Android.-.Native.3.mov
Android: mWeb Chrome
Android.-.Chrome.3.mov
iOS: Native
iOS.-.Native.3.MP4
iOS: mWeb Safari
RPReplay_Final1697576834.MP4
MacOS: Chrome / Safari
MacOS.-.Chrome.mov
MacOS.-.Safari.3.mov
Recording.5051.mp4
MacOS: Desktop
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: