[$500] Web - Login - Error page is displayed after changing the long URL to staging and go to it

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR: #28984

Version Number: 1.3.86-1

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

Action Performed:

Pre-requisite: user must be logged in with account A on expensify.com and account B on new.expensify.com

1. With account B on expensify.com go to Support and select Concierge.
2. A new tab will open with a long URL, copy it.
3. Change the URL to staging.new.expensify.com and go to it.

Expected Result:

User A should be successfully logged in to ND with no error pages displayed.

Actual Result:

User A is logged in but there is an error page displayed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6241329_1697603277658.bandicam_2023-10-17_21-59-49-598.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b109095a56a932b9
• Upwork Job ID: 1714580146381455361
• Last Price Increase: 2023-10-18
• Automatic offers:
• cubuspl42 | Reviewer | 27258677

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b109095a56a932b9

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[izarutskaya]

Not reproducible in production

20231018_114714.mp4

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[hungvu193]

It was intended to be fixed by this PR #28984
However I still can reproduce this issue. So I think it can be regression from it.

[koko57]

yes, it's also reproducible locally. Not sure why the id for Concierge chat changes to the id for Concierge chat from the previously log out account

it tested well before merging my PR, so maybe some other changes were introduced that caused the issue with mine

I'll investigate it

[melvin-bot]

📣 @cubuspl42 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[mountiny]

Thanks for investigating, maybe we can also confirm if revert fixes this, there could be some other change

[mountiny]

I think the steps should say With account A on expensify.com go to Support and select Concierge. right?

[koko57]

reverting my changes gives me totally black screen - not like in the issue I tried to fix (an empty sidebar and green background)

[Beamanator]

Hey @koko57 - has there been any more investigation in the last 4 hours? 😅 I didn't see that I am assigned to look into this as well 😳

[koko57]

When I removed demoInfo key from withOnyx in AuthScreens (with my changes reverted) I got the same outcome as in the issue I was fixing (green background, empty sidebar). Then I restored the changes and noticed that at first the user is redirected to the correct chat (the one with id from the transition url) but right afterwards there's a redirection to this improper chat. I haven't found the reason why this happens. I'll continue investigating it tomorrow

[francoisl]

Discussed in Slack in this thread, this is an edge case so we'll not block the deploy for this.
I also got a crash on production when I tried to reproduce this, so there might be an issue there anyway.

[koko57]

Reverting this empty string to null in this line fixes the issue 😃

App/src/pages/home/ReportScreen.js

Line 130 in eb5fec2

return String(lodashGet(route, 'params.reportID', ''));

and seems that it doesn't introduce any regression.
However, it only unveiled some other problems with the transition. Starting working on my proposal

[koko57]

I've merged with the latest main and '' in this line

App/src/pages/home/ReportScreen.js

Lines 130 to 131 in b20766b

	// // The reportID is used inside a collection key and should not be empty, as an empty reportID will result in the entire collection being returned.
	return String(lodashGet(route, 'params.reportID', null));

was changed back to null so locally there's no problem with the transtition.

Screen.Recording.2023-10-20.at.17.48.50.mov

for the transition to staging there's still a problem, but it's because this PR hasn't been deployed to staging yet.

[mountiny]

@koko57 thank you! would you be able to make a new PR?

[koko57]

@mountiny do we need a new PR here? This PR fixes this

[mountiny]

ah yes sorry I forgot we did not end up reverting your PR, so then we are all good

[Beamanator]

Ok so we can close this one out, yeah?