Chat - Selected receipt date is changed to priviuse date

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.86.1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Go to Fab menu
2. Select scan
3. Select media
4. Tap on any receipt
5. Select user
6. Tap Request
7. open receipt when it in Scanning progress
8. Change the receipt date

Expected Result:

The selected date should be saved

Actual Result:

Selected receipt date is changed to priviuse date

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Bug6241734_1697635168824.Screen_Recording_20231017_225555_New_Expensify__1_.mp4

Android: mWeb Chrome

iOS: Native

Bug6241734_1697635168824.Screen_Recording_20231017_225555_New_Expensify__1_.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

Recording.5056.mp4

MacOS: Desktop

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[cooldev900]

Proposal

from: @cooldev900

Please re-state the problem that we are trying to solve in this issue.

The Date of Birth field selects a different date instead of the selected date

What is the root cause of that problem?

It comes from this PR, #29062

The root cause is that it does not take into account the difference between New Date('YYYY-MM-DD') and New Date(Year, Month, Day).
https://stackoverflow.com/questions/25865051/javascript-difference-between-new-datedatestring-vs-new-dateyear-month

App/src/components/NewDatePicker/CalendarPicker/index.js

Line 208 in 9d79fd1

const isSelected = isSameDay(new Date(this.props.value), new Date(currentYearView, currentMonthView, day));

What changes do you think we should make in order to solve the problem?

We should use a consistent approach when handling dates.
const isSelected = this.props.value === format(currentDate, CONST.DATE.FNS_FORMAT_STRING);

What alternative solutions did you explore? (Optional)

[b4s36t4]

I'm not able to reproduce this

[b4s36t4]

any specific steps??

[s-alves10]

This is a regression of this PR #29062

[tewodrosGirmaA]

@b4s36t4 Hey guys, I actually reported this issue on Slack before it was posted on Github. You can find my original report at https://expensify.slack.com/archives/C049HHMV9SM/p1697608053386949?thread_ts=1697608053.386949&cid=C049HHMV9SM."

[kbecciv]

@b4s36t4 Another scenario:

1. Go to Settings > Profile > Personal Details > Date of Birth
2. Click on the Date of Birth field and select a date
3. Observe that the selected date is not saved,
   Expected Result: The selected date should be saved in the Date of Birth field.
   Actual Result: The Date of Birth field selects a different date instead of the selected date.

Screen.Recording.2023-10-17.at.10.47.55.PM.mov

[mountiny]

@waterim the author is looking into this, if they cant find a solution, we can revert

[francoisl]

Couldn't see an obvious fix for this, so for now we'll go ahead with this revert so we can unblock the deploy.

[mountiny]

@waterim lets focus on this testing moving ahead, although I swear this worked on our PR maybe there is some prerequisite

[mountiny]

@lschurr could you please pay $50 to @tewodrosGirmaA for reporting. thanks!

[lschurr]

Yep! I invited you to the job @tewodrosGirmaA - https://www.upwork.com/jobs/~017dd56ff525a2ca36

[tewodrosGirmaA]

Hello @lschurr , i accepted the invitation, Thank you 😊

[lschurr]

Payment sent. Closing!