Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-30] Remove and fix some TODOs that exist in the code #29879

Closed
tgolen opened this issue Oct 18, 2023 · 6 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@tgolen
Copy link
Contributor

tgolen commented Oct 18, 2023

Problem

Some TODOs exist in our code that are not helpful or are not consistently labeled.

This is coming from my large refactoring PR in an attempt to break it down into smaller pieces

Why this is important

It creates confusion and inconsistency

Solution

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01329374af863b4abc
  • Upwork Job ID: 1714682014816800768
  • Last Price Increase: 2023-10-18
@tgolen tgolen added Engineering Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff labels Oct 18, 2023
@tgolen tgolen self-assigned this Oct 18, 2023
@melvin-bot

This comment was marked as off-topic.

@melvin-bot

This comment was marked as off-topic.

@tgolen

This comment was marked as off-topic.

@tgolen tgolen added the Reviewing Has a PR in review label Oct 18, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 18, 2023
@melvin-bot melvin-bot bot changed the title Remove and fix some TODOs that exist in the code [HOLD for payment 2023-10-30] Remove and fix some TODOs that exist in the code Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 29, 2023
@tgolen
Copy link
Contributor Author

tgolen commented Oct 30, 2023

This was done internally so there are no payments.

@tgolen tgolen closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

2 participants