Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] [ECard Settings] Card Settings Follow Up #30067

Closed
grgia opened this issue Oct 20, 2023 · 5 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@grgia
Copy link
Contributor

grgia commented Oct 20, 2023

Implement changes from pending slack convo - https://expensify.slack.com/archives/C027726KHT4/p1697778334627559

  • Show wallet card if user has an available balance
  • Fix missing BG color behind animation
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bbe8007fd38ca212
  • Upwork Job ID: 1715311128445767680
  • Last Price Increase: 2023-10-20
@grgia grgia self-assigned this Oct 20, 2023
@grgia grgia added the Internal Requires API changes or must be handled by Expensify staff label Oct 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01bbe8007fd38ca212

@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @narefyev91 (Internal)

@grgia grgia changed the title [ECard Settings] Show Wallet if User has a Balance [ECard Settings] Card Settings Follow Up Oct 20, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 21, 2023
@melvin-bot melvin-bot bot changed the title [ECard Settings] Card Settings Follow Up [HOLD for payment 2023-10-30] [ECard Settings] Card Settings Follow Up Oct 23, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 24, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-10-30] [ECard Settings] Card Settings Follow Up [HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] [ECard Settings] Card Settings Follow Up Oct 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 24, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.89-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-31. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 29, 2023
@grgia grgia closed this as completed Oct 31, 2023
@melvin-bot melvin-bot bot removed the Overdue label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

2 participants