-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-11-29] [$500] The email addresses of mentioned users in the "Invited" message are not copied along with the message #30272
Comments
Job added to Upwork: https://www.upwork.com/jobs/~0138b8048fa3e5a82c |
Triggered auto assignment to @stephanieelliott ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.The email addresses of mentioned users in the "Invited" message are not copied when copying to clipboard What is the root cause of that problem?Invited message contains
But the current htmlToMarkdown or htmlToText engine doesn't take care of the new format of What changes do you think we should make in order to solve the problem?We need to care about the new type of user mentions
Note: Shouldn't be the last rule in
and update App/src/components/Composer/index.js Line 252 in 4430ae2
to
This way, we can process the new type of user mentions Resultissue_04.mp4What alternative solutions did you explore? (Optional) |
@cubuspl42, @stephanieelliott Huh... This is 4 days overdue. Who can take care of this? |
Hey @cubuspl42 looks like we have a few proposals here -- can you review when you have a sec? |
@s-alves10 While this idea is interesting, I don't believe that ExpensiMark is the appropriate abstraction level to solve this problem. ExpensiMark is abstracted from Expensify domain logic and it should stay that way. |
The solution suggested by @dukenv0307 is reasonable and should be relatively simple to implement. I approve it. C+ reviewed 🎀 👀 🎀 |
Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Thank you for reviewing the proposal. Here is my question. cc @bondydaa |
📣 @cubuspl42 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
📣 @ayazhussain79 We're missing your Upwork ID to automatically send you an offer for the Reporter role. |
@cubuspl42 The PR is ready for reiview. |
PR approved but undergoing QA |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.1-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-11-29. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Hey @cubuspl42 can you complete the BZ checklist when you get a chance? |
Summarizing payment on this issue:
Upwork job is here |
|
@stephanieelliott Offer accepted, Thank you |
All paid up, thanks! Issue for regression test here: https://github.com/Expensify/Expensify/issues/new |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.3.90-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698094454192599
Action Performed:
Expected Result:
The email addresses of mentioned users in the "Invited" message should also be copied along with the message
Actual Result:
The email addresses of mentioned users in the "Invited" message are not copied with the message
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Android: Native
Screen.Recording.2023-10-24.at.2.47.36.AM.mov
Android: mWeb Chrome
Screen.Recording.2023-10-24.at.3.07.33.AM.mov
iOS: Native
Screen.Recording.2023-10-24.at.2.20.00.AM.mov
iOS: mWeb Safari
Screen.Recording.2023-10-24.at.2.17.26.AM.mov
MacOS: Chrome / Safari
Recording.153.mp4
MacOS: Desktop
Screen.Recording.2023-10-24.at.2.14.09.AM.mov
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: