Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Disable logs from staging and production native apps #30571

Closed
mountiny opened this issue Oct 30, 2023 · 13 comments
Closed

[$500] Disable logs from staging and production native apps #30571

mountiny opened this issue Oct 30, 2023 · 13 comments
Assignees
Labels
External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@mountiny
Copy link
Contributor

mountiny commented Oct 30, 2023

cc @perunt @kidroca

Coming from here, we would like to disable the logs in native devices when the ENV is staging or production as we can see they can have certain effect on the performance.

We will keep the logs for web as there the performance effect is not so significant

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0196038043ae5d7c60
  • Upwork Job ID: 1719690288548622336
  • Last Price Increase: 2023-11-01
@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels Oct 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 30, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 30, 2023
@trjExpensify
Copy link
Contributor

@mountiny mind confirming what you want to do with this issue? Who should it get assigned to?

@mountiny
Copy link
Contributor Author

This will be worked on externally so we might need to pay out later, waiting for @kidroca to confirm if he wants to work on this or if we should make this external

@trjExpensify
Copy link
Contributor

Cool, sounds good!

@kidroca
Copy link
Contributor

kidroca commented Oct 30, 2023

Thanks! I'd like to take this one

@mountiny mountiny assigned kidroca and unassigned kidroca Nov 1, 2023
@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Nov 1, 2023
Copy link

melvin-bot bot commented Nov 1, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0196038043ae5d7c60

@melvin-bot melvin-bot bot changed the title Disable logs from staging and production native apps [$500] Disable logs from staging and production native apps Nov 1, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 1, 2023
Copy link

melvin-bot bot commented Nov 1, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 1, 2023
@mountiny
Copy link
Contributor Author

mountiny commented Nov 1, 2023

@kidroca could you please post a proposal before starting a PR, thanks!

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 1, 2023
@kidroca
Copy link
Contributor

kidroca commented Nov 1, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app's UI experiences sluggish performance at times. Preliminary investigation points to console logging as a significant contributor to this issue.

What is the root cause of that problem?

Console logging is a known performance bottleneck in React Native apps. It was initially disabled in production but was later re-enabled for debugging purposes. The problem lies in the excessive amount of logging, which impacts performance. For example, simple actions like switching chats generate around 400 lines of logs within a few seconds.

What changes do you think we should make in order to solve the problem?

  1. Disable Console Logging: We should disable console logging in the production build to enhance app performance. This is a standard practice in React Native apps.
  • we'd still keep logging for web/desktop as logging shouldn't be affecting performance noticeable there, and these are the platforms where users can actually provide the logs easily. Related slack comment.
  1. Collect User Feedback: Post-implementation, we should collect user feedback to evaluate the impact on UI responsiveness and overall app performance.

What alternative solutions did you explore? (Optional)

We could implement a feature to allow users to manually send the current log buffer to technical support for debugging. However, this would require additional development time and does not immediately address the performance issue.


Expected Outcomes: Improved app performance and a better user experience.

References: The official React Native documentation advises minimizing the use of console logging in production builds for better performance.

@mountiny
Copy link
Contributor Author

mountiny commented Nov 2, 2023

@kidroca since you are already assigned, just go ahead and create the PR, thank you!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 3, 2023
@mountiny mountiny self-assigned this Nov 5, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 7, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Nov 30, 2023
Copy link

melvin-bot bot commented Nov 30, 2023

This issue has not been updated in over 15 days. @kidroca, @trjExpensify, @mountiny, @robertKozik eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mountiny
Copy link
Contributor Author

mountiny commented Dec 1, 2023

@kidroca will handle payments elsewhere, I think we can close this issue now.

Thank you!

@mountiny mountiny closed this as completed Dec 1, 2023
@JmillsExpensify
Copy link

Removed the invoice for @kidroca's work and I approve payment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
Development

No branches or pull requests

5 participants