Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Chat - If there is a previous money request on chat, the last message is not visible in LHN #31194

Closed
2 of 6 tasks
lanitochka17 opened this issue Nov 10, 2023 · 8 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 10, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.98-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #29939

Action Performed:

Pre-requisite: must be logged in and have a chat where you have previously requested money

  1. Open a chat where you have a previous money request
  2. Send any message (note that it appears in LHN)
  3. Create a new money request
  4. Disable internet connection
  5. Delete the last money request

Expected Result:

The last sent message should be visible in LHN

Actual Result:

The previous money request is visible in LHN, not the last message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6271550_1699637921348.bandicam_2023-11-10_12-46-00-496.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0170cc5bfea21c8189
  • Upwork Job ID: 1723039479388102656
  • Last Price Increase: 2023-11-10
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 10, 2023
@melvin-bot melvin-bot bot changed the title Chat - If there is a previous money request on chat, the last message is not visible in LHN [$500] Chat - If there is a previous money request on chat, the last message is not visible in LHN Nov 10, 2023
Copy link

melvin-bot bot commented Nov 10, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0170cc5bfea21c8189

Copy link

melvin-bot bot commented Nov 10, 2023

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 10, 2023
Copy link

melvin-bot bot commented Nov 10, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Nov 10, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@tienifr
Copy link
Contributor

tienifr commented Nov 10, 2023

This is already behavior on production. If you have only one request with B, then when you delete it, LHN would show last visible message. But if you have multiple requests, LHN would show total amount.

@s77rt
Copy link
Contributor

s77rt commented Nov 12, 2023

This seems to be working as expected.

@s77rt
Copy link
Contributor

s77rt commented Nov 12, 2023

@Christinadobrzyn Can we close this?

@Christinadobrzyn
Copy link
Contributor

Awesome, thanks @s77rt and @tienifr! I'll close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

4 participants