[$500] Workspace - Bank account setup page appears briefly when opening BA when BA is already set up

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.3.98-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to Settings > Workspaces > any workspace.
3. Click Bank account.
4. Click Connect online with Plaid.
5. Continue bank account setup with Plaid until it is successful.
6. Return to workspace settings.
7. Click Bank account again.

Expected Result:

User is redirected to disconnect bank account screen.

Actual Result:

Bank account setup page shows up briefly.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6271728_1699646112669.20231111_025419.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e6c09018ece00b54
• Upwork Job ID: 1723072485931921408
• Last Price Increase: 2023-11-10

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e6c09018ece00b54

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[erquhart]

@izarutskaya completing this flow requires successful Onfido verification, which it doesn't seem is possible without submitting my real ID and biometric data. Your steps to reproduce don't include Onfido - is there a way to reproduce this without going through these extra verified bank account steps?

[jliexpensify]

Great question @erquhart - in Old Dot, there's a method to bypass Onfido to manually add an account but I can't see that option in New Dot. Have asked our team here re: Onfido.

[roryabraham]

This appears to be a legitimate bug, but I don't think we should block deploy on it.

[melvin-bot]

Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new.

[jliexpensify]

I don't think this is a deploy blocker but bumping @tylerkaraszewski as the assigned engineer

[tylerkaraszewski]

I'm not really sure what the course of action here is, either. I guess I need to fix this now?

[jliexpensify]

Yep I think so @tylerkaraszewski - I'll drop this down to Weekly since it's not an actual deploy blocker, but I believe you'll need to push out a PR.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

@tylerkaraszewski @rushatgabhane @jliexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@tylerkaraszewski, @rushatgabhane, @jliexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[tylerkaraszewski]

I have not worked on this. What's the priority of stuff like this with a waves focus?

[aldo-expensify]

Sounds like a regression. We used to show a loading indicator while the bank account data is not loaded yet. The loader indicator code is here:

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Lines 414 to 422 in 10310d8

	if ((!this.state.hasACHDataBeenLoaded || isLoading) && shouldShowOfflineLoader && (shouldReopenOnfido || !this.requestorStepRef.current)) {
	const isSubmittingVerificationsData = _.contains([CONST.BANK_ACCOUNT.STEP.COMPANY, CONST.BANK_ACCOUNT.STEP.REQUESTOR, CONST.BANK_ACCOUNT.STEP.ACH_CONTRACT], currentStep);
	return (
	<ReimbursementAccountLoadingIndicator
	isSubmittingVerificationsData={isSubmittingVerificationsData}
	onBackButtonPress={this.goBack}
	/>
	);
	}

[jliexpensify]

Thanks @aldo-expensify - can you link the PR, or unassign Tyler/re-assign the C+ from the PR?

[aldo-expensify]

I tried to find it, but the file's history is a bit messy because of a few reverts that have happen in the last couple of months.

[melvin-bot]

@tylerkaraszewski @rushatgabhane @jliexpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

@tylerkaraszewski, @rushatgabhane, @jliexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jliexpensify]

@aldo-expensify would you recommend posting in #bug-zero and asking who worked on the PR and linking this job?

[aldo-expensify]

Wouldn't hurt to ask, I haven't have the time to look at it again.

[jliexpensify]

Asked here and here to all C+

[ntdiary]

I feel this issue is caused by PR #29166. We had a similar issue #31212, which also bypassed the hasACHDataBeenLoaded condition. And we've fixed the related condition in the new PR #31439 (already merged), so I guess this issue will be resolved as well, can you please test it again?

cc @jliexpensify @aldo-expensify @izarutskaya

[jliexpensify]

Ooh nice, thanks so much @ntdiary - @izarutskaya do you mind confirming this is fixed?

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[jliexpensify]

Great, lets close this off!