Hold #28997 [$500] Mweb/Chrome - Thread - Tapping leave thread, displays "U" for a second instead of Room name in header #31220

lanitochka17 · 2023-11-10T22:49:54Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.98-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Go to https://staging.new.expensify.com/
Tap on a room with a thread reply message
Tap on reply
Tap 3 dots on top
Select Leave thread

Expected Result:

Tapping leave thread, must not display unavailable "U" for a second instead of Room name in header

Actual Result:

Tapping leave thread, displays unavailable "U" for a second instead of Room name in header.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6271878_1699653563009.u.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014350424b71769cdf
Upwork Job ID: 1723110772857241600
Last Price Increase: 2024-01-12

melvin-bot · 2023-11-10T22:49:58Z

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-11-10T22:49:59Z

Job added to Upwork: https://www.upwork.com/jobs/~014350424b71769cdf

melvin-bot · 2023-11-10T22:50:00Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-11-10T22:50:04Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

DylanDylann · 2023-11-11T03:12:37Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mweb/Chrome - Thread - Tapping leave thread, displays "U" for a second instead of Room name in header

What is the root cause of that problem?

After clicking on "Leave thread", we set the optimistic data for this thread as below:

App/src/libs/actions/Report.ts

Lines 2103 to 2118 in 52adf77

    
           const optimisticData: OnyxUpdate[] = [ 
        
               { 
        
                   onyxMethod: Onyx.METHOD.MERGE, 
        
                   key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`, 
        
                   value: isWorkspaceMemberLeavingWorkspaceRoom 
        
                       ? { 
        
                             notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN, 
        
                         } 
        
                       : { 
        
                             reportID: null, 
        
                             stateNum: CONST.REPORT.STATE_NUM.APPROVED, 
        
                             statusNum: CONST.REPORT.STATUS_NUM.CLOSED, 
        
                             notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN, 
        
                         }, 
        
               }, 
        
           ];

Then we use this useEffect to handle case onyxReportID: undefined. It will navigate the user to the previous report.
When the above useEffect executing, it will display the above optimistic report for a while.

What changes do you think we should make in order to solve the problem?

We need to navigate the user to the parent report after API call, the same as what we did in case we left the room. Can do it by updating

App/src/libs/actions/Report.js

Lines 2087 to 2091 in f285c9c

    
           if (isWorkspaceMemberLeavingWorkspaceRoom) { 
        
               const participantAccountIDs = PersonalDetailsUtils.getAccountIDsByLogins([CONST.EMAIL.CONCIERGE]); 
        
               const chat = ReportUtils.getChatByParticipants(participantAccountIDs); 
        
               Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(chat.reportID)); 
        
           }

to

  if (isWorkspaceMemberLeavingWorkspaceRoom) {
        const participantAccountIDs = PersonalDetailsUtils.getAccountIDsByLogins([CONST.EMAIL.CONCIERGE]);
        const chat = ReportUtils.getChatByParticipants(participantAccountIDs);
        Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(chat.reportID));
+     } else {
+        Navigation.goBack();
+    }

What alternative solutions did you explore? (Optional)

Also we can hide the Join button (and the HeaderView) once the report.reportID is empty as we did in other screens.
To hide the Join button, we can update:

App/src/pages/home/HeaderView.js

Line 155 in 52adf77

const canJoin = canJoinOrLeave && !isWhisperAction && props.report.notificationPreference === CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN;

to

   const canJoin = props.report.reportID && canJoinOrLeave && !isWhisperAction && props.report.notificationPreference === CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN;

If we want to hide the header as well, update:

App/src/pages/home/HeaderView.js

Line 217 in 52adf77

const isLoading = !props.report || !title;

to:

    const isLoading = !props.report.reportID || !props.report || !title;

bernhardoj · 2023-11-11T04:37:44Z

Should be fixed in #28997

laurenreidexpensify · 2023-11-14T10:44:34Z

@eVoloshchak do you agree this will be covered in #28997 and we can close?

melvin-bot · 2023-11-17T16:00:07Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

laurenreidexpensify · 2023-11-20T11:04:11Z

@eVoloshchak bump

DylanDylann · 2023-11-20T11:23:56Z

@eVoloshchak I think the RCA of this issue (31220) is that we do not navigate user to the parent thread after leaving thread. The 28997 is about the behavior when we re-join the leaved thread. Both of them are not the same. Also, we are still discussing about the expected solution for 28997

eVoloshchak · 2023-11-21T21:56:37Z

#28997 and this issue do have different causes, but depending on which approach will be taken to fix #28997 this one might be resolved too (#28997 (comment))

@laurenreidexpensify, let's put this on HOLD for #28997

melvin-bot · 2023-11-24T16:00:16Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

laurenreidexpensify · 2023-11-30T10:55:17Z

Still on hold on #28997

melvin-bot · 2023-12-01T16:00:19Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

laurenreidexpensify · 2023-12-05T15:49:29Z

Still on hold on #28997

melvin-bot · 2023-12-08T16:00:34Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

laurenreidexpensify · 2023-12-14T12:17:07Z

Still on hold on #28997 but that has payment due on 15 Dec - so should be off hold v soon

melvin-bot · 2023-12-15T16:00:42Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

laurenreidexpensify · 2023-12-20T10:26:19Z

@eVoloshchak #28997 has been on prod for a solid 12 days now, can we lift the hold?

eVoloshchak · 2023-12-22T14:53:34Z

@laurenreidexpensify, according to my tests, this was resolved by a fix for #28997.
Would like for someone from QA to double check that

melvin-bot · 2023-12-22T16:00:34Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

laurenreidexpensify · 2023-12-29T10:10:53Z

@Expensify/applauseleads please confirm if this is still reproducible in KI tests

melvin-bot · 2023-12-29T16:00:56Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

laurenreidexpensify · 2024-01-04T11:47:41Z

@applausebot please confirm if this is still reproducible in KI tests

melvin-bot · 2024-01-05T16:00:48Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot · 2024-01-12T16:00:43Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

laurenreidexpensify · 2024-01-15T15:11:30Z

I am closing based on @eVoloshchak's comment that this is resolved

lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 10, 2023

melvin-bot bot changed the title ~~Mweb/Chrome - Thread - Tapping leave thread, displays "U" for a second instead of Room name in header~~ [$500] Mweb/Chrome - Thread - Tapping leave thread, displays "U" for a second instead of Room name in header Nov 10, 2023

melvin-bot bot assigned laurenreidexpensify Nov 10, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 10, 2023

melvin-bot bot assigned eVoloshchak Nov 10, 2023

melvin-bot bot added the Overdue label Nov 13, 2023

eh2077 mentioned this issue Nov 13, 2023

Feat: drop user to last chat after leaving a room #31097

Merged

50 tasks

melvin-bot bot added Overdue and removed Overdue labels Nov 14, 2023

melvin-bot bot removed the Overdue label Nov 20, 2023

laurenreidexpensify changed the title ~~[$500] Mweb/Chrome - Thread - Tapping leave thread, displays "U" for a second instead of Room name in header~~ h[$500] Mweb/Chrome - Thread - Tapping leave thread, displays "U" for a second instead of Room name in header Nov 22, 2023

laurenreidexpensify changed the title ~~h[$500] Mweb/Chrome - Thread - Tapping leave thread, displays "U" for a second instead of Room name in header~~ Hold ##28997 [$500] Mweb/Chrome - Thread - Tapping leave thread, displays "U" for a second instead of Room name in header Nov 22, 2023

laurenreidexpensify changed the title ~~Hold ##28997 [$500] Mweb/Chrome - Thread - Tapping leave thread, displays "U" for a second instead of Room name in header~~ Hold #28997 [$500] Mweb/Chrome - Thread - Tapping leave thread, displays "U" for a second instead of Room name in header Nov 22, 2023

laurenreidexpensify added Weekly KSv2 and removed Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 22, 2023

melvin-bot bot added the Overdue label Dec 14, 2023

melvin-bot bot removed the Overdue label Dec 14, 2023

melvin-bot bot added the Overdue label Jan 12, 2024

laurenreidexpensify closed this as completed Jan 15, 2024

melvin-bot bot removed the Overdue label Jan 15, 2024

DylanDylann mentioned this issue Jan 20, 2024

[HOLD for payment 2024-02-07] [$500] Thread - "Join" button appear when user Leave thread #34820

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hold #28997 [$500] Mweb/Chrome - Thread - Tapping leave thread, displays "U" for a second instead of Room name in header #31220

Hold #28997 [$500] Mweb/Chrome - Thread - Tapping leave thread, displays "U" for a second instead of Room name in header #31220

lanitochka17 commented Nov 10, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Nov 10, 2023

melvin-bot bot commented Nov 10, 2023

melvin-bot bot commented Nov 10, 2023

melvin-bot bot commented Nov 10, 2023

DylanDylann commented Nov 11, 2023 •

edited

Loading

bernhardoj commented Nov 11, 2023

laurenreidexpensify commented Nov 14, 2023

melvin-bot bot commented Nov 17, 2023

laurenreidexpensify commented Nov 20, 2023

DylanDylann commented Nov 20, 2023 •

edited

Loading

eVoloshchak commented Nov 21, 2023

melvin-bot bot commented Nov 24, 2023

laurenreidexpensify commented Nov 30, 2023

melvin-bot bot commented Dec 1, 2023

laurenreidexpensify commented Dec 5, 2023

melvin-bot bot commented Dec 8, 2023

laurenreidexpensify commented Dec 14, 2023

melvin-bot bot commented Dec 15, 2023

laurenreidexpensify commented Dec 20, 2023

eVoloshchak commented Dec 22, 2023

melvin-bot bot commented Dec 22, 2023

laurenreidexpensify commented Dec 29, 2023

melvin-bot bot commented Dec 29, 2023

laurenreidexpensify commented Jan 4, 2024

melvin-bot bot commented Jan 5, 2024

melvin-bot bot commented Jan 12, 2024

laurenreidexpensify commented Jan 15, 2024

Hold #28997 [$500] Mweb/Chrome - Thread - Tapping leave thread, displays "U" for a second instead of Room name in header #31220

Hold #28997 [$500] Mweb/Chrome - Thread - Tapping leave thread, displays "U" for a second instead of Room name in header #31220

Comments

lanitochka17 commented Nov 10, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Nov 10, 2023

melvin-bot bot commented Nov 10, 2023

melvin-bot bot commented Nov 10, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Nov 10, 2023

DylanDylann commented Nov 11, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

bernhardoj commented Nov 11, 2023

laurenreidexpensify commented Nov 14, 2023

melvin-bot bot commented Nov 17, 2023

laurenreidexpensify commented Nov 20, 2023

DylanDylann commented Nov 20, 2023 • edited Loading

eVoloshchak commented Nov 21, 2023

melvin-bot bot commented Nov 24, 2023

laurenreidexpensify commented Nov 30, 2023

melvin-bot bot commented Dec 1, 2023

laurenreidexpensify commented Dec 5, 2023

melvin-bot bot commented Dec 8, 2023

laurenreidexpensify commented Dec 14, 2023

melvin-bot bot commented Dec 15, 2023

laurenreidexpensify commented Dec 20, 2023

eVoloshchak commented Dec 22, 2023

melvin-bot bot commented Dec 22, 2023

laurenreidexpensify commented Dec 29, 2023

melvin-bot bot commented Dec 29, 2023

laurenreidexpensify commented Jan 4, 2024

melvin-bot bot commented Jan 5, 2024

melvin-bot bot commented Jan 12, 2024

laurenreidexpensify commented Jan 15, 2024

lanitochka17 commented Nov 10, 2023 •

edited by melvin-bot bot

Loading

DylanDylann commented Nov 11, 2023 •

edited

Loading

DylanDylann commented Nov 20, 2023 •

edited

Loading