Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Chat - Link in Code block is broken #31305

Closed
5 of 6 tasks
kbecciv opened this issue Nov 14, 2023 · 18 comments
Closed
5 of 6 tasks

[$500] Chat - Link in Code block is broken #31305

kbecciv opened this issue Nov 14, 2023 · 18 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Nov 14, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.98.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Open the app

  2. Open any report

  3. Send link in following format:
    image

  4. Observe that format is broken

Expected Result:

Link in Code block should display correctly

Actual Result:

Link in Code block is broken

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.5391.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018d375f943b53855b
  • Upwork Job ID: 1724409048072474624
  • Last Price Increase: 2023-11-21
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 14, 2023
@melvin-bot melvin-bot bot changed the title Chat - Link in Code block is broken [$500] Chat - Link in Code block is broken Nov 14, 2023
Copy link

melvin-bot bot commented Nov 14, 2023

Job added to Upwork: https://www.upwork.com/jobs/~018d375f943b53855b

Copy link

melvin-bot bot commented Nov 14, 2023

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 14, 2023
Copy link

melvin-bot bot commented Nov 14, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Nov 14, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

@kbecciv
Copy link
Author

kbecciv commented Nov 14, 2023

Issue found when executing Monthly Edge TC #22492

@paultsimura
Copy link
Contributor

According to the original issue (#22492), this is the expected behavior, isn't it?

Copy link

melvin-bot bot commented Nov 14, 2023

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

@SamanKT
Copy link

SamanKT commented Nov 14, 2023

Contributor details
Your Expensify account email: saman.khataei@hotmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01d45dab5b311d5e84

Copy link

melvin-bot bot commented Nov 14, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@ikevin127
Copy link
Contributor

// We don't want to apply link rule if match[1] contains the code block inside the [] of the markdown e.g. [```example```](https://example.com) or if match[1] is multiline text preceeded by markdown heading, e.g., # [example\nexample\nexample](https://example.com)

from:
https://github.com/Expensify/expensify-common/blob/04e6315adc870127b281de2ad16a1db5b325d065/lib/ExpensiMark.js#L522-L523

This is the expected behaviour according to this merged PR, as seen in one of the videos:

254840948-66d14c1c-3efc-424e-8312-ffc7e9550cdc.mov

Copy link

melvin-bot bot commented Nov 14, 2023

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

@rchrdschfr
Copy link

It seems possible that this is the expected behaviour as others have pointed out. However, if it's not expected behaviour, then how should the link be formatted?

Copy link

melvin-bot bot commented Nov 15, 2023

📣 @rchrdschfr! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@rchrdschfr
Copy link

Contributor details
Your Expensify account email: rchrdschfr@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0170400e57082f5461

Copy link

melvin-bot bot commented Nov 15, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2023
@laurenreidexpensify
Copy link
Contributor

@Ollyws can you review links and confirm if this expected behaviour as the others have suggested? Thanks

@melvin-bot melvin-bot bot removed the Overdue label Nov 20, 2023
Copy link

melvin-bot bot commented Nov 21, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Nov 22, 2023
@Ollyws
Copy link
Contributor

Ollyws commented Nov 22, 2023

Yeah this seems to be the expected behaviour as outlined in #23247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

7 participants