Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2023-12-08] [Theme Switching Migration] Navigation + SignIn + WholeApp Batch #31684

Closed
12 tasks
grgia opened this issue Nov 22, 2023 · 8 comments
Closed
12 tasks

[HOLD for payment 2023-12-08] [Theme Switching Migration] Navigation + SignIn + WholeApp Batch #31684

grgia opened this issue Nov 22, 2023 · 8 comments
Assignees
@koko57 @grgia @lukemorawski
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2

Comments

@grgia
Copy link
Contributor

grgia commented Nov 22, 2023 •
edited
Loading

Part of #31677

As part of the Theme Switching Project, we need to migrate the following:

  • ModalStackNavigators.js,
  • NavigationRoot.js,
  • Terms.js
  • GrowlNotification/index.js
  • getRootNavigatorScreenOptions.js
  • src/libs/Navigation/AppNavigator/getRootNavigatorScreenOptions.js
  • src/libs/Navigation/AppNavigator/Navigators/CentralPaneNavigator/BaseCentralPaneNavigator.js
  • src/libs/Navigation/AppNavigator/RHPScreenOptions.js
  • src/libs/Navigation/AppNavigator/getRootNavigatorScreenOptions.js
  • src/pages/signin/SignInPageLayout/signInPageStyles/index.native.js
  • src/pages/signin/SignInPageLayout/signInPageStyles/index.js
  • src/components/ScreenWrapper/index.js
@grgia grgia self-assigned this Nov 22, 2023
@grgia grgia added the Daily KSv2 label Nov 22, 2023
@koko57
Copy link
Contributor

koko57 commented Nov 22, 2023

leaving a comment to be assigned :)

@lukemorawski
Copy link
Contributor

taking care of this one

@koko57
Copy link
Contributor

koko57 commented Nov 22, 2023

We can add these files to this batch:
getRootNavigatorScreenOptions.js
src/libs/Navigation/AppNavigator/getRootNavigatorScreenOptions.js
src/libs/Navigation/AppNavigator/Navigators/CentralPaneNavigator/BaseCentralPaneNavigator.js
src/libs/Navigation/AppNavigator/RHPScreenOptions.js
src/libs/Navigation/AppNavigator/getRootNavigatorScreenOptions.js
src/pages/signin/SignInPageLayout/signInPageStyles/index.native.js
src/pages/signin/SignInPageLayout/signInPageStyles/index.js
src/components/ScreenWrapper/index.js

@grgia
Copy link
Contributor Author

grgia commented Nov 22, 2023

updated description and assigned @lukemorawski

@lukemorawski lukemorawski mentioned this issue Nov 22, 2023
Merged
47 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 22, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 1, 2023
@melvin-bot melvin-bot bot changed the title [Theme Switching Migration] Navigation + SignIn + WholeApp Batch [HOLD for payment 2023-12-08] [Theme Switching Migration] Navigation + SignIn + WholeApp Batch Dec 1, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 1, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 1, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 1, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.6-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 8, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 11, 2023

@koko57, @grgia, @lukemorawski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 13, 2023

@koko57, @grgia, @lukemorawski Huh... This is 4 days overdue. Who can take care of this?

@grgia grgia closed this as completed Dec 13, 2023
@melvin-bot melvin-bot bot removed the Overdue label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koko57 koko57

@grgia grgia

@lukemorawski lukemorawski

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2
Projects
No open projects
Theme Switching / Light Mode
Status: Done - Live ✅
Milestone
No milestone
Development

No branches or pull requests
3 participants
@koko57 @grgia @lukemorawski