Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-12] [Theme Switching] Enable theme switching for status and scrollbar colors #31915

Closed
grgia opened this issue Nov 27, 2023 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@grgia
Copy link
Contributor

grgia commented Nov 27, 2023

We need to ensure that the status bar and scrollbar both change when the theme is changed cc @chrispader

@grgia grgia self-assigned this Nov 27, 2023
@grgia grgia added the Daily KSv2 label Nov 27, 2023
@chrispader
Copy link
Contributor

comment for assigning :)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 27, 2023
Copy link

melvin-bot bot commented Dec 2, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 5, 2023
@melvin-bot melvin-bot bot changed the title [Theme Switching] Enable theme switching for status and scrollbar colors [HOLD for payment 2023-12-12] [Theme Switching] Enable theme switching for status and scrollbar colors Dec 5, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 5, 2023
Copy link

melvin-bot bot commented Dec 5, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 5, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.7-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 11, 2023
@grgia grgia added the NewFeature Something to build that is a new item. label Dec 13, 2023
Copy link

melvin-bot bot commented Dec 13, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue Daily KSv2 labels Dec 13, 2023
@grgia
Copy link
Contributor Author

grgia commented Dec 13, 2023

hey @anmurali could you help me out with the $500 C+ review payment to @fedirjh?

@anmurali
Copy link

Sent offer here

@fedirjh
Copy link
Contributor

fedirjh commented Dec 14, 2023

@anmurali Thank you. Accepted!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Dec 24, 2023
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Jan 16, 2024
Copy link

melvin-bot bot commented Jan 16, 2024

This issue has not been updated in over 15 days. @anmurali, @grgia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jan 16, 2024
@grgia grgia closed this as completed Jan 16, 2024
@fedirjh
Copy link
Contributor

fedirjh commented Jan 16, 2024

cc @anmurali, Payment was not processed for this one: https://www.upwork.com/nx/wm/workroom/35742470/overview

Screenshot 2024-01-16 at 8 49 05 PM

@grgia grgia added Weekly KSv2 Daily KSv2 and removed Monthly KSv2 Weekly KSv2 labels Jan 17, 2024
@fedirjh
Copy link
Contributor

fedirjh commented Feb 12, 2024

@anmurali Friendly bump.

@fedirjh
Copy link
Contributor

fedirjh commented Mar 7, 2024

cc @grgia Could you please reopen this issue? The payment was not completed for this one. It's been 3 months overdue.

@grgia grgia reopened this Mar 11, 2024
@grgia
Copy link
Contributor Author

grgia commented Mar 11, 2024

Apologies @fedirjh, reopened and brought to slack https://expensify.slack.com/archives/C01SKUP7QR0/p1710167128836029

@mallenexpensify
Copy link
Contributor

Contributor+: @fedirjh paid $500 via Upwork.

Apologies @fedirjh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
No open projects
Development

No branches or pull requests

5 participants