Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] [TS migration] Migrate 'LocationErrorMessage' component to TypeScript #31967

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 21 comments
Closed

[$250] [TS migration] Migrate 'LocationErrorMessage' component to TypeScript #31967

melvin-bot bot opened this issue Nov 27, 2023 · 21 comments
Assignees
@puneetlath @youssef-lr @HezekielT @shubham1206agra
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023 •
edited
Loading

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/LocationErrorMessage/locationErrorMessagePropTypes.js 1
src/components/LocationErrorMessage/index.native.js 4
src/components/LocationErrorMessage/index.js 5
src/components/LocationErrorMessage/BaseLocationErrorMessage.js 15
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a7a7aa2f001b93cc
  • Upwork Job ID: 1736777403476488192
  • Last Price Increase: 2023-12-18
  • Automatic offers:
    • shubham1206agra | Reviewer | 28069446
    • HezekielT | Contributor | 28069447
@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Dec 18, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'LocationErrorMessage' component to TypeScript [$500] [TS migration] Migrate 'LocationErrorMessage' component to TypeScript Dec 18, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 18, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01a7a7aa2f001b93cc

@melvin-bot melvin-bot bot added Overdue Help Wanted Apply this label when an issue is open to proposals by contributors labels Dec 18, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 18, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Overdue Weekly KSv2 labels Dec 18, 2023
@mountiny mountiny changed the title [$500] [TS migration] Migrate 'LocationErrorMessage' component to TypeScript [$250] [TS migration] Migrate 'LocationErrorMessage' component to TypeScript Dec 18, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 18, 2023

⚠️ Failed to update price automatically. The BZ team member will need to update the price manually in Upwork.

@HezekielT
Copy link
Contributor

I would like to work on this.

@MahmudjonToraqulov
Copy link
Contributor

I would like to work on this

@ZhenjaHorbach

This comment was marked as outdated.

Sign in to view
@shubham1206agra
Copy link
Contributor

@HezekielT is first here
🎀 👀 🎀 C+ reviewed

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 18, 2023

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@yh-0218
Copy link
Contributor

yh-0218 commented Dec 18, 2023

I would like to work on this issue

@shahinyan11 shahinyan11 mentioned this issue Dec 19, 2023
Closed
@melvin-bot melvin-bot bot added the Overdue label Dec 21, 2023
@youssef-lr youssef-lr added the Reviewing Has a PR in review label Dec 22, 2023
@melvin-bot melvin-bot bot removed the Overdue label Dec 22, 2023
@HezekielT
Copy link
Contributor

HezekielT commented Dec 25, 2023 •
edited
Loading

@shubham1206agra I have to be assigned first before creating a PR. right? Or should I raise a PR without being assigned?
cc @youssef-lr

@shubham1206agra
Copy link
Contributor

I think you will be assigned here shortly
You can raise the PR in the meantime

@shubham1206agra
Copy link
Contributor

@youssef-lr can you do the assignment here whenever you are available?

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 25, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 25, 2023

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 25, 2023

📣 @HezekielT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@HezekielT HezekielT mentioned this issue Dec 26, 2023
Merged
50 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Dec 26, 2023
@HezekielT
Copy link
Contributor

@shubham1206agra PR is ready for review.

@HezekielT HezekielT mentioned this issue Jan 10, 2024
Closed
@HezekielT
Copy link
Contributor

@youssef-lr @shubham1206agra It seems the automation failed for this issue but the pr was deployed a week ago and I think it's ready for payment.
image

Could you please look into this? Thanks

@Julesssss Julesssss added the Bug Something is broken. Auto assigns a BugZero manager. label Feb 1, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Feb 1, 2024

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 1, 2024
@Julesssss
Copy link
Contributor

Hey @puneetlath can you just pay out for a C+ payment please. Thanks

@puneetlath
Copy link
Contributor

@HezekielT has been paid.

@shubham1206agra sent you a new offer here: https://www.upwork.com/nx/wm/offer/100725434. Please ping me on this issue when you've accepted it.

@shubham1206agra
Copy link
Contributor

Accepted

@puneetlath
Copy link
Contributor

All paid. Thanks y'all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@puneetlath puneetlath

@youssef-lr youssef-lr

@HezekielT HezekielT

@shubham1206agra shubham1206agra

Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Task Typescript Migration
Projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
9 participants
@puneetlath @youssef-lr @Julesssss @mountiny @HezekielT @shubham1206agra @yh-0218 @ZhenjaHorbach @MahmudjonToraqulov