[HOLD for payment 2024-02-07] [$250] [TS migration] Migrate 'Form' component to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/components/Form/errorsPropType.js	1
src/components/Form/InputWrapper.js	3
src/components/Form/FormWrapper.js	13
src/components/Form/FormProvider.js	15
src/components/Form/FormContext.js	1

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b00649428ca23975
• Upwork Job ID: 1750472759181078528
• Last Price Increase: 2024-01-25

[blazejkustra]

Hey! This is something that was recently implemented by @kowczarz, I think he should take this one 😄

[fabioh8010]

@blazejkustra WDYT about doing InputWrapper and in a separate PR? We can suppress this error temporally, I think it should be enough.

// src/components/Form/InputWrapper.tsx

// @ts-expect-error TODO: Remove this when FormContext is migrated to TS.
const {registerInput} = useContext(FormContext);

This way we could unblock ~47 pages. Do you think is it possible or it makes sense?

[blazejkustra]

InputWrapper and in a separate PR?

InputWrapper and what else?

[fabioh8010]

@blazejkustra I was thinking about this and InputWrapper is always used together with FormProvider, which would require us to migrate it and the others 😞 . The only exception seems to be DatePicker which is a component that uses it but doesn't use FormProvider. Do you think is worth it opening a PR to migrate InputWrapper in order to help unblock DatePicker?

Anyway, I tested the migration of this file yesterday and was able to do it, here is the branch.

[blazejkustra]

This way we could unblock ~47 pages

@fabioh8010 If this really unblocks almost 50 pages, I think we should do it! Especially looking at your branch which is a fairly simple migration 😄

[blazejkustra]

FYI I started working on this issue this week, here is a draft PR

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b00649428ca23975

[allgandalf]

i can work on this issue

[LeOndaz]

I can work on this issue, I applied to the Upwork job post

https://www.upwork.com/freelancers/leondaz

[melvin-bot]

📣 @LeOndaz! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[blazejkustra]

@RohanSasne @AnshuAgarwal24 @abzokhattab @LeOndaz This issue isn't external, so please do not comment for assignment 😄 (PR is almost merged)

[LeOndaz]

Contributor details
Your Expensify account email: ahmeddark369@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/leondaz

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS migration] Migrate 'Form' component to TypeScript #32992

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @blazejkustra does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[isabelastisser]

@allroundexperts, can you please complete the task above? Thanks!

[dangrous]

I don't think we need any new regression steps - if this PR does what it should, there should be no change at all (for users) from the existing Form!

[isabelastisser]

Thanks for clarifying, Daniel!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @allroundexperts owed $500 via NewDot
• Contributor: @blazejkustra is from an agency-contributor and not due payment

BugZero Checklist (@isabelastisser)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1750472759181078528/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[isabelastisser]

Reviewing.

[isabelastisser]

Payment Summary

Reviewer: @allroundexperts owed $250 via NewDot

PENDING payment in NewDot.

[isabelastisser]

Closing this, but we're still pending Payment in NewDot. cc @JmillsExpensify ^^

[JmillsExpensify]

$250 approved for @allroundexperts based on summary above.