-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-03-14] [HOLD #36406][TS migration] Migrate 'fs.js' mock to TypeScript #32006
Comments
This issue has not been updated in over 15 days. eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Hello! How do I start contributing to the project? |
📣 @ParamBirje! 📣
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
Thank you! I'll ping this thread again when starting to work on the issue. |
I'm developing in a Linux environment and want to start contributing to migration issues. I don't currently have access to a Mac. While working on migrations, is it necessary to test the app on all platforms? I can test on other platforms like Android, Web and mWeb. |
Hi, I'm Jakub from Callstack - expert contributor group - and I would like to take a look at this issue. |
Triggered auto assignment to @mallenexpensify ( |
@kubabutkiewicz can you provide an update plz? |
Hi @mallenexpensify waiting for this #36406 to be merged because its switching imports to ES6 imports and I have a comment about that in my Draft PR |
Thanks @kubabutkiewicz , I'll hang tight over here :) |
Actually this PR got merged yesterday so I can got back to my issue :) |
Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-03-14. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Closing, @kubabutkiewicz paid via agency. |
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
The text was updated successfully, but these errors were encountered: