-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Invalid phone number is accepted when starting a new chat #32242
Comments
Triggered auto assignment to @NicMendonca ( |
Bug0 Triage Checklist (Main S/O)
|
Job added to Upwork: https://www.upwork.com/jobs/~01b8deeaa5835d9589 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary ( |
Please re-state the problem that we are trying to solve in this issue.Invalid phone number is accepted when starting a new chat What is the root cause of that problem?the country code 1 is removed from the number +112345678900 resulting in +12345678900, might occur due to how the country code addition and formatting are handled in the context of the awesome-phonenumber library. What changes do you think we should make in order to solve the problem?https://github.com/Expensify/App/blob/main/src/libs/OptionsListUtils.js#L1623
this will set the error if the input and e164 value is not same which solves the problem of not showing error message also to hide the popup we need to wrap in condition,
Video:https://drive.google.com/file/d/1FcEDYvB6-CxJ7WZsStJkBJ9FKr0zIFTz/view?usp=drive_link |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Taking over as C+ here. The existing proposals do not adequately address the issue. Looking for more proposals. |
ProposalPlease re-state the problem that we are trying to solve in this issue.An invalid phone number is accepted when starting a new chat. What is the root cause of that problem?The core issue at hand stems from the functionality of the
While the What changes do you think we should make in order to solve the problem?We can improve the existing code by adding an extra check, comparing the e164 and input values for equality.
We'll also need to add the Bug-fix demo:Screenshot of expected result: Video showing expected behavior: Screen.Recording.2023-12-05.at.1.11.20.PM.mov |
📣 @erichasinternet! 📣
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
This will be fixed by #31726 |
@ntdiary, @NicMendonca Huh... This is 4 days overdue. Who can take care of this? |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.5-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @MariaHCD
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1701265640069269
Action Performed:
Expected Result:
Invalid number should be detected
Actual Result:
The number is parsed into a valid phone number
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: