-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] [Wave 6: Tags] Expense - Selected subcategory shows different view in Tag & Category #32489
Comments
Triggered auto assignment to @CortneyOfstad ( |
Job added to Upwork: https://www.upwork.com/jobs/~019f4d74182e84937e |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.When requesting money manually, the list options for Tags and Categories do use a uniform format for displaying selected subcategories. What is the root cause of that problem?The file What changes do you think we should make in order to solve the problem?Update the What alternative solutions did you explore? (Optional)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Selected subcateogry shows differently in Category and Tag. What is the root cause of that problem?We are passing App/src/libs/OptionsListUtils.js Line 826 in d77121b
so it is shown in one line whereas for tags we use no flag so the default flag is false
What changes do you think we should make in order to solve the problem?We should remove the flag for App/src/libs/OptionsListUtils.js Line 826 in d77121b
If we want to show hierarchical view everywhere we can remove all true flags like here for searchApp/src/libs/OptionsListUtils.js Line 840 in d77121b
On the other hand if we like to follow the view of category for tags, we pass the App/src/libs/OptionsListUtils.js Line 956 in d77121b
and here App/src/libs/OptionsListUtils.js Line 970 in d77121b
What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.The selected subcategory does not show the same view in Tag and Category What is the root cause of that problem?We're not using What changes do you think we should make in order to solve the problem?Use What alternative solutions did you explore? (Optional)NA |
@lanitochka17 @c3024 @tienifr @happy-devs I don't see anything after the category. Could you tell me what I did wrong? |
@shahinyan11 looks like this is only in the dev environment, not the https://new.expensify.com portal |
Please follow this. |
already fixed |
@thesahindia can you confirm if this was fixed via the linked PR above? TIA! |
Bump @thesahindia ^^^ Thanks! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@CortneyOfstad Issue is still reproducible 20231214_215846.mp4 |
Thanks @kbecciv! Will keep this open while we wait for proposals! |
@CortneyOfstad, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@CortneyOfstad, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@CortneyOfstad @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue. |
confirmed here that the features are actually working as designed. The tags do not interact the same as the categories in this instance, so the issue can be closed 👍 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.8-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Precondition: The workspace chat has some tags in Parent: Child format
Expected Result:
The selected subcategory will show the same view in Tag and Category
Actual Result:
The selected subcategory does not show the same view in Tag and Category
For Tag, the selected subcategory is in hierarchy order
For Category, the selected subcategory is in Parent: Child format
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6301777_1701779561826.bandicam_2023-12-05_15-18-59-178.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: