[$500] [Wave 6: Tags] Expense - Selected subcategory shows different view in Tag & Category

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.8-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: The workspace chat has some tags in Parent: Child format

1. Go to workspace chat
2. Click + > Request money > Manual
3. Enter amount > Continue
4. Click Show more > Tag
5. Select a subcategory
6. Click Tag
7. Repeat Step 1 to 6 with Category

Expected Result:

The selected subcategory will show the same view in Tag and Category

Actual Result:

The selected subcategory does not show the same view in Tag and Category
For Tag, the selected subcategory is in hierarchy order
For Category, the selected subcategory is in Parent: Child format

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6301777_1701779561826.bandicam_2023-12-05_15-18-59-178.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019f4d74182e84937e
• Upwork Job ID: 1732061052657393664
• Last Price Increase: 2023-12-12

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019f4d74182e84937e

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[happy-devs]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When requesting money manually, the list options for Tags and Categories do use a uniform format for displaying selected subcategories.

What is the root cause of that problem?

The file OptionsListUtils has to be changed to fix the rendering of child and parent for tags.

What changes do you think we should make in order to solve the problem?

Update the OptionsListUtils functions to ensure that both Tags and Categories use the same format.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Selected subcateogry shows differently in Category and Tag.

What is the root cause of that problem?

We are passing true here for isOneLine

App/src/libs/OptionsListUtils.js

Line 826 in d77121b

data: getIndentedOptionTree(selectedOptions, true),

so it is shown in one line whereas for tags we use no flag so the default flag is false

What changes do you think we should make in order to solve the problem?

We should remove the flag for isOneLine here if we want to show category options also in hierarchical view

App/src/libs/OptionsListUtils.js

Line 826 in d77121b

data: getIndentedOptionTree(selectedOptions, true),

If we want to show hierarchical view everywhere we can remove all true flags like here for search

App/src/libs/OptionsListUtils.js

Line 840 in d77121b

data: getIndentedOptionTree(searchCategories, true),

On the other hand if we like to follow the view of category for tags, we pass the true flag for tags here

App/src/libs/OptionsListUtils.js

Line 956 in d77121b

data: getTagsOptions(selectedTagOptions),

and here

App/src/libs/OptionsListUtils.js

Line 970 in d77121b

data: getTagsOptions(searchTags),

What alternative solutions did you explore? (Optional)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The selected subcategory does not show the same view in Tag and Category
For Tag, the selected subcategory is in hierarchy order
For Category, the selected subcategory is in Parent: Child format

What is the root cause of that problem?

We're not using isOneLine true in tags

What changes do you think we should make in order to solve the problem?

Use isOneLine true in tags

What alternative solutions did you explore? (Optional)

NA

[shahinyan11]

@lanitochka17 @c3024 @tienifr @happy-devs I don't see anything after the category. Could you tell me what I did wrong?

[happy-devs]

@shahinyan11 looks like this is only in the dev environment, not the https://new.expensify.com portal

[c3024]

Please follow this.

[FitseTLT]

already fixed

[CortneyOfstad]

@thesahindia can you confirm if this was fixed via the linked PR above? TIA!

[CortneyOfstad]

Bump @thesahindia ^^^ Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[kbecciv]

@CortneyOfstad Issue is still reproducible

20231214_215846.mp4

[CortneyOfstad]

Thanks @kbecciv! Will keep this open while we wait for proposals!

[melvin-bot]

@CortneyOfstad, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@CortneyOfstad, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@CortneyOfstad @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[CortneyOfstad]

confirmed here that the features are actually working as designed. The tags do not interact the same as the categories in this instance, so the issue can be closed 👍