[$500] scroll bar on enable wallet page is in the middle of the screen on mobile

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @grgia
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1703194885001139

Action Performed:

1. Open app
2. Go to settings
3. Tap wallet
4. Tap "enable wallet"

Expected Result:

Scrollbar should not appear in the middle

Actual Result:

scroll bar on enable wallet page is in the middle of the screen on mobile. Additionally three of the values read N/A and it’s unclear if that’s intentional.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

RPReplay_Final1703194694.MP4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019e6f43e90acfc383
• Upwork Job ID: 1739090412690550784
• Last Price Increase: 2024-01-01

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

scroll bar on enable wallet page is in the middle of the screen on iOS

What is the root cause of that problem?

react-navigation/react-navigation#8452
This is upstream issue so transition switch between navigation stacks when the screen stack that we navigate to uses ScrollView.

What changes do you think we should make in order to solve the problem?

Add scrollIndicatorInsets={{right: Number.MIN_VALUE}} to ScrollView in TermsStep.js. (same solution as #31608)

If needed, we can apply to same to other pages where same issue happens.

[bfitzexpensify]

I can't reproduce because I don't have a gold wallet, but sending this one external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019e6f43e90acfc383

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Scroll bar in the task confirmation page is on the left.
It reappears on the right when backgrounding and relaunching the app.

What is the root cause of that problem?

When the ScrollView is mounted when screen animation is in progress, since iOS will adjust scroll indicator insets by default, sometimes it will stuck in the middle/left of the screen. This issue is explained quite well in this thread facebook/react-native#26610. The automaticallyAdjustsScrollIndicatorInsets by default will be true for ScrollView in iOS, and it's like that for a purpose. If it's false, this issue will occur.

Having automaticallyAdjustsScrollIndicatorInsets set to true is Apple's intended behavior. With this set to false, the user will not be able to tell whether or not there is more to scroll on devices with rounded corners, or with ScrollViews underneath native navigation bars or tab bars. See screenshots.

What changes do you think we should make in order to solve the problem?

We should create the ScrollView component within enableScrollIndicatorLTR props (default is true), and replace all current ScrollView with the new one

function ScrollView({enableScrollIndicatorLTR=true}) {
return <RNScrollView
...
scrollIndicatorInsets={enableScrollIndicatorLTR && {right: Number.MIN_VALUE}}

What alternative solutions did you explore? (Optional)

[tienifr]

I already posted the proposal in other issue before

[Santhosh-Sellavel]

Unassigning this one due to low bandwidth please assign a new C+ here @bfitzexpensify

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[bfitzexpensify]

How do these proposals look @sobitneupane?

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

@sobitneupane, @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[bfitzexpensify]

Let's close this as not reproducible.