Chat - Hidden is not shown when starting new chat with a user without previous conversation

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.21-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Search for a public domain user that you have never chatted before
2. Observe the name when the conversation is opened

Expected Result:

Hidden should be shown as the name and on LHN

Actual Result:

Hidden is not shown but email is shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6331563_1704308267587.nothidden.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

Not reproduced on Production

hiddenprod.mp4

[NikkiWines]

I'm unable to reproduce this on staging v1.4.21-1 in MacOS Chrome. @kbecciv can you confirm this is reproducible on staging?

Screen.Recording.2024-01-03.at.14.33.34.mov

[kbecciv]

@NikkiWines I can reproduce on staging v1.4.21-1

Recording.5802.mp4

[NikkiWines]

Weird, ok! Thank you for double checking! I'll continue to dig into it

[paultsimura]

Couldn't reproduce in dev & staging either 🤔

[NikkiWines]

Seems like this might be tied to #32613? @puneetlath do you know of anything that went to staging recently that might be causing this?

[puneetlath]

I think you're likely able to see that user's personal details because you were the one that invited them @kbecciv.

[puneetlath]

We did make some back-end changes, but I don't think this is a bug.

[NikkiWines]

Sounds good, removing the blocker label then. Thanks @puneetlath!

[puneetlath]

@kbecciv was this bug a result of a regression test? I think we might need to update the test as the scenario here, the user should actually "know" the other user and thus not see "hidden".

[lanitochka17]

@puneetlath Hello
https://expensify.testrail.io/index.php?/tests/view/4151387

[kbecciv]

@puneetlath Correct, the bug a result of a regression test, please attach TR https://expensify.testrail.io/index.php?/tests/view/4151387

[melvin-bot]

@puneetlath Eep! 4 days overdue now. Issues have feelings too...

[puneetlath]

@lanitochka17 @kbecciv can we just remove that test? It's no longer relevant with the changes we're making.

[puneetlath]

Bumped Maria bout removing the test here: https://expensify.slack.com/archives/C9YU7BX5M/p1707322780645939

[isagoico]

Deleted the TC (https://expensify.testrail.io/index.php?/cases/view/2778068) that covered this flow.

[puneetlath]

Thanks @isagoico!