-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Room - For WS added as member, title is displayed but for room, title is not displayed #33903
Comments
Job added to Upwork: https://www.upwork.com/jobs/~012834976e9aca901a |
Triggered auto assignment to @puneetlath ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.For WS added as member, title is displayed but for room, title is not displayed What is the root cause of that problem?When the App/src/pages/RoomMembersPage.js Lines 214 to 215 in 27a51a4
What changes do you think we should make in order to solve the problem?We should pass the
Should do the same for workspace members page too App/src/pages/workspace/WorkspaceMembersPage.js Lines 367 to 368 in 27a51a4
What alternative solutions did you explore? (Optional) |
This may be fixed as a part of #31312, where the getDisplayName methods should be consolidated, and the fallback to login will be standard practice. |
@paultsimura Thanks for mentioning #31312! Yes, @puneetlath I think it can be done as a part of the refactor 🙂 |
Great, makes sense to me. I'll assign you to this one as well @koko57 |
📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
@puneetlath Can we put this on hold for #33930 |
I tried to recreate the original issue but I couldn't. Unfortunately, I didn't record the trial with the number from the steps: +15082211111. I tried with other numbers and got this result: Screen.Recording.2024-01-09.at.10.14.25.mp4So either it's fixed and we have a login (here phone number) displayed as a fallback or there's something wrong with a particular phone number. @kbecciv if the issue still exists could you provide another number to test? I've noticed another issue while trying to recreate the original bug - it doesn't happen all the time, I only experienced it a few times - the item with the user name disappears when choosing the invitee (checking the checkbox) Screen.Recording.2024-01-09.at.10.18.09.mp4 |
@kbecciv could you please confirm it's still reproducible? |
@koko57 Issue is reproducible with Phone number +15082211196 az_recorder_20240110_214431.mp4 |
@kbecciv I couldn't recreate it :/ Screen.Recording.2024-01-10.at.17.58.34.mp4 |
Let's close this then. Feel free to comment/reopen if anyone is able to consistently reproduce. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.21-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
+15082211111
Expected Result:
If specific number contact +15082211111, added to workspace, displayed with title. Similarly, the same number contact added to room, must be displayed with title and title must not be disappeared.
Actual Result:
If specific number contact +15082211111, added to workspace, displayed with title but same number contact added to room, displayed with title for a second and then title disappeared.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6331609_1704311026003.no_title.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: