[$500] Room - For WS added as member, title is displayed but for room, title is not displayed

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.21-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Copy phone number +15082211111
3. Tap on profile icon---- Workspaces----- Workspace
4. Tap on members
5. Tap invite
6. Paste the number +15082211111
7. Tap invite
8. Note, in newly added members list, number is added with title.
9. Navigate to LHN
10. Tap in a room chat
11. Tap header--- members--- Invite
12. Paste the number
    +15082211111
13. Tap invite
14. Note, in newly added members list, number is added with title but disappeared within seconds.

Expected Result:

If specific number contact +15082211111, added to workspace, displayed with title. Similarly, the same number contact added to room, must be displayed with title and title must not be disappeared.

Actual Result:

If specific number contact +15082211111, added to workspace, displayed with title but same number contact added to room, displayed with title for a second and then title disappeared.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6331609_1704311026003.no_title.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012834976e9aca901a
• Upwork Job ID: 1742635293250863104
• Last Price Increase: 2024-01-03
• Automatic offers:
• s77rt | Reviewer | 28081124

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012834976e9aca901a

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

For WS added as member, title is displayed but for room, title is not displayed

What is the root cause of that problem?

When the displayName is empty for the personal detail PersonalDetailsUtils.getDisplayNameOrDefault returns empty string as we haven't given the defaultValue (login) here

App/src/pages/RoomMembersPage.js

Lines 214 to 215 in 27a51a4

	text: props.formatPhoneNumber(PersonalDetailsUtils.getDisplayNameOrDefault(details)),
	alternateText: props.formatPhoneNumber(details.login),

What changes do you think we should make in order to solve the problem?

We should pass the login as a fallback for the case displayName is empty

                text: props.formatPhoneNumber(PersonalDetailsUtils.getDisplayNameOrDefault(details, details.login)),

Should do the same for workspace members page too

App/src/pages/workspace/WorkspaceMembersPage.js

Lines 367 to 368 in 27a51a4

	text: props.formatPhoneNumber(PersonalDetailsUtils.getDisplayNameOrDefault(details)),
	alternateText: props.formatPhoneNumber(details.login),

What alternative solutions did you explore? (Optional)

[paultsimura]

This may be fixed as a part of #31312, where the getDisplayName methods should be consolidated, and the fallback to login will be standard practice.

[koko57]

@paultsimura Thanks for mentioning #31312! Yes, @puneetlath I think it can be done as a part of the refactor 🙂

[puneetlath]

Great, makes sense to me. I'll assign you to this one as well @koko57

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[s77rt]

@puneetlath Can we put this on hold for #33930

[koko57]

I tried to recreate the original issue but I couldn't. Unfortunately, I didn't record the trial with the number from the steps: +15082211111. I tried with other numbers and got this result:

Screen.Recording.2024-01-09.at.10.14.25.mp4

So either it's fixed and we have a login (here phone number) displayed as a fallback or there's something wrong with a particular phone number. @kbecciv if the issue still exists could you provide another number to test?

I've noticed another issue while trying to recreate the original bug - it doesn't happen all the time, I only experienced it a few times - the item with the user name disappears when choosing the invitee (checking the checkbox)

Screen.Recording.2024-01-09.at.10.18.09.mp4

[koko57]

@kbecciv could you please confirm it's still reproducible?

[kbecciv]

@koko57 Issue is reproducible with Phone number +15082211196

az_recorder_20240110_214431.mp4

[koko57]

@kbecciv I couldn't recreate it :/

Screen.Recording.2024-01-10.at.17.58.34.mp4

[puneetlath]

Let's close this then. Feel free to comment/reopen if anyone is able to consistently reproduce.