-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] IOU - SmartScan accepts ZIP archives for scanning #34061
Comments
Job added to Upwork: https://www.upwork.com/jobs/~0127a303a9dda156f9 |
Triggered auto assignment to @trjExpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.SmartScan accepts ZIP archives for scanning What is the root cause of that problem?This happens as we allow zip as receipt extension here: Lines 58 to 59 in f5a3c02
What changes do you think we should make in order to solve the problem?We should remove |
This looks like an intentional behavior in #29960 |
@trjExpensify Can you confirm internally if zip is allowed or not? |
Yep, just checked the backend on main and zip is still allowed (internal ref). Closing! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
IOU SmartScan should not accept ZIP archives for scanning
Actual Result:
IOU SmartScan accepts ZIP archives for scanning
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6333456_1704483585528.Recording__1044.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: