[$500] IOU - SmartScan accepts ZIP archives for scanning

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open New Expensify app
2. Log in to your HT account
3. Tap on the green plus button (FAB)
4. Select Request money
5. Click the Scan tab
6. Drag and drop the Zip archive on the scan modal
7. Select any user or WS
8. Complete the request

Expected Result:

IOU SmartScan should not accept ZIP archives for scanning

Actual Result:

IOU SmartScan accepts ZIP archives for scanning

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6333456_1704483585528.Recording__1044.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0127a303a9dda156f9
• Upwork Job ID: 1743368526458941440
• Last Price Increase: 2024-01-05

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0127a303a9dda156f9

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

SmartScan accepts ZIP archives for scanning

What is the root cause of that problem?

This happens as we allow zip as receipt extension here:

App/src/CONST.ts

Lines 58 to 59 in f5a3c02

	// Allowed extensions for receipts
	ALLOWED_RECEIPT_EXTENSIONS: ['jpg', 'jpeg', 'gif', 'png', 'pdf', 'htm', 'html', 'text', 'rtf', 'doc', 'tif', 'tiff', 'msword', 'zip', 'xml', 'message'],

What changes do you think we should make in order to solve the problem?

We should remove .zip as an allowed receipt extension.

[s-alves10]

This looks like an intentional behavior in #29960

[shubham1206agra]

@trjExpensify Can you confirm internally if zip is allowed or not?

[trjExpensify]

Yep, just checked the backend on main and zip is still allowed (internal ref). Closing!