[HOLD for payment 2024-01-31] predeploy.yml Github Action is broken in main

[blimpich]

Problem

The e2ePerformanceTests / Build apk from latest release as a baseline step of the predeploy.yml has been failing consistently for about 25 runs (as of writing this issue). This appears to be happening since #33645 was merged into main. Looking at one of the failed runs it appears to be Android related (link).

Solution

Investigate why the GH Action is failing consistently and provide a solution for it.

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hannojg]

I don't think the issue is related to that specific PR, but it's a problem people are having at the moment in general when building react native from source.
The issue is with boost and is reported here:

• Downloads failing for boostorg.jfrog.io, affecting several important packages boostorg/boost#849

[hannojg]

I am investigating if we can patch react native for a fix - but it might be that the boost archives are just broken on their servers - lets see.

[greg-schroeder]

Where did you land on this @hannojg?

[hannojg]

Sorry, forgot to update here!
This was a bug in react-native and should be fixed with this PR:

• chore: Update React Native to 0.73.2 #31558

(As per this and this thread)

[blimpich]

Huh, I'm still seeing the process new code merged to main workflow failing with what I think is the same error.

[blimpich]

Conversation for this going on in slack here:

https://expensify.slack.com/archives/C05LX9D6E07/p1705092756559629?thread_ts=1704755329.727759&cid=C05LX9D6E07

https://expensify.slack.com/archives/C05LX9D6E07/p1704755329727759

[melvin-bot]

@greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

[hannojg]

So it seems like there is a new issue now with the build step:

* What went wrong:
A problem occurred evaluating project ':app'.
> Failed to apply plugin 'com.android.internal.application'.
   > Android Gradle plugin requires Java 17 to run. You are currently using Java 11.
      Your current JDK is located in /usr/lib/jvm/temurin-11-jdk-amd64
      You can try some of the following options:
       - changing the IDE settings.
       - changing the JAVA_HOME environment variable.
       - changing `org.gradle.java.home` in `gradle.properties`.

[melvin-bot]

@greg-schroeder Huh... This is 4 days overdue. Who can take care of this?

[blimpich]

Huh, weird. @Julesssss @AndrewGable are you aware of any changes that might have caused the gradle issue that @hannojg mentioned?

[hannojg]

d541723#diff-9526ccfd1d1813ed49c39f8c54dbeb512607376a007d824b905bc8b4e4d202d9 I think this commit may caused the issue.

I can look into it more detail tomorrow if no one is working on that already?
(Can't open the slack link unfortunately for some reason)

[blimpich]

@hannojg that sounds good. I don't think anyone else is looking into this right now. And sorry I don't know what happened with that slack link but I think this one should work: https://expensify.slack.com/archives/C05LX9D6E07/p1704755329727759

[blimpich]

Assigning to you @hannojg so that Melvin will count your updates and stop saying that this issue is overdue.

[Julesssss]

I don't see what change could have caused this, but if we're to take logs at face value we might need to set the JDK version that github Actions run against. Though again I'm confused as to why this would occur out of nowhere 😕

[hannojg]

Yeah same @Julesssss the fix is probably quite simple but weird that it randomly happened. Didn't find the time today to push a PR - will do tmrw!

[hannojg]

PR is up:

• dev: fix failing e2ePerformanceTest android build step #34786

[hannojg]

We just merged the PR. Seems like the issue is fixed:

However, right now, we check out the latest release version for the baseline app. This release currently doesn't include the new build action. So we have to wait for a new release for the pipeline to work again:

[blimpich]

Sounds good, we can wait ⏳

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.30-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• dev: fix failing e2ePerformanceTest android build step #34786

If no regressions arise, payment will be issued on 2024-01-31. 🎊

For reference, here are some details about the assignees on this issue:

• @hannojg does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [] The PR that introduced the bug has been identified. Link to the PR:
• [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hannojg] Determine if we should create a regression test for this bug.
• [@hannojg] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[greg-schroeder]

No payments required - Margelo + internal reviews