Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task - Error shows up when creating task via [] @mention <task name> pathway #34250

Closed
6 tasks done
lanitochka17 opened this issue Jan 10, 2024 · 9 comments
Closed
6 tasks done
Assignees
Labels
Daily KSv2 Engineering Needs Reproduction Reproducible steps needed

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.24-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #33428

Action Performed:

  1. Go to an empty 1:1 DM
  2. Send [] @mention where @mention is not the DM user

Expected Result:

The task is created and assigned to the mentioned user.

Actual Result:

The task is not created. Error shows up - Unexpected error create task, please try again later

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6337787_1704899132724.bandicam_2024-01-10_19-16-59-338.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 10, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 10, 2024

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@danieldoglas
Copy link
Contributor

Assigning @thienlnam since he's been working on this with the contributors on this functionality

But I was not able to simulate this error both on DMs and group chats when inviting people that were not participants, @lanitochka17

@danieldoglas
Copy link
Contributor

I'm not sure if this is the desired behavior, but:

  • I had a chat with user 1
  • created a task using the md syntax for user 2
  • The task was created, assigned to user 2, but also shared with user 1
  • The task was listed in both 1:1 chats I had with user 1 and user 2

@thienlnam I'll let you chime in from there!

@iwiznia
Copy link
Contributor

iwiznia commented Jan 10, 2024

Following because I was testing with him and I thought the behavior was weird/wrong. IMO the user2 should NOT see the task in the DM report, they should only see it in the LHN.

@thienlnam
Copy link
Contributor

thienlnam commented Jan 11, 2024

I'm not sure if this is the desired behavior, but:
I had a chat with user 1
created a task using the md syntax for user 2
The task was created, assigned to user 2, but also shared with user 1
The task was listed in both 1:1 chats I had with user 1 and user 2

Yes this is correct behavior - so let's take User A and User B

  • You're chatting in the DM with User A
  • In that DM, you create a task for User B ([] @userb task)
  • In the DM with User B, you get linked to the task that was created in the DM with User A

@thienlnam
Copy link
Contributor

I tested this and this seems to be working fine for me - not able to get the failure as mentioned and neither can Daniel so going to remove the blocker

@thienlnam thienlnam added Daily KSv2 Needs Reproduction Reproducible steps needed and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 11, 2024
@iwiznia
Copy link
Contributor

iwiznia commented Jan 11, 2024

In the DM with User B, you get linked to the task that was created in the DM with User A

ok but can you explain why? To me this does not make any sense. That task and conversation did not happen in the DM with user B, why would it show up there?

@thienlnam
Copy link
Contributor

It did not, but you're taking an action that requires something of someone else.
I assigned the task to you specifically, and so it will show up in the DM between us even if it was created somewhere else.

Side note - going to be closing this issue since this bug doesn't seem to be happening. Happy to talk this through more in slack if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

4 participants