[HOLD for payment 2024-02-07] Private note - Private note opened from deeplink in offline shown empty

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.24-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31257

Action Performed:

1. Open any chat and select a Contact to view their details.
2. Open a note and copy its link (URL) and paste and send to the chat
3. Log out and login again
4. Open the same chat and disconnect
5. Open the deeplink of the note in edit mode
6. Turn on the internet connection.

Expected Result:

The note is opened in edit mode and can be seen fully

Actual Result:

An empty note is opened in edit mode after the connection recovers

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6337960_1704907498398.BUG_in_staging_Recording__579.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[lanitochka17]

Production:

Bug6337960_1704907498405.Production_Recording__583.mp4

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

when opening the deeplink in offline and connecting to the ne twork .. an empty private note appear

What is the root cause of that problem?

the loader indicator is not shown in case the isPrivateNotesFetchTriggered is false

App/src/pages/home/report/withReportAndPrivateNotesOrNotFound.js

Line 79 in 48ab68e

const shouldShowFullScreenLoadingIndicator = !isPrivateNotesFetchTriggered || (isPrivateNotesEmpty && (report.isLoadingPrivateNotes || !isOtherUserNote));

here we can find the isPrivateNotesFetchTriggered var initialization:

App/src/pages/home/report/withReportAndPrivateNotesOrNotFound.js

Line 63 in 48ab68e

const isPrivateNotesFetchTriggered = !_.isUndefined(report.isLoadingPrivateNotes);

as you can notice we only check the existence of the report.isLoadingPrivateNotes prop we dont check if the value is true or false

and since in the optimistic value we set the report.isLoadingPrivateNotes to true then the isLoadingPrivateNotes value will be defined and the isPrivateNotesFetchTriggered will be true in this case and thus the loader indicator disappears.

the issue here occurs because at the optimistic stage the data is not yet fetched from the database so the report data will not contain the privateNote
this happens

What changes do you think we should make in order to solve the problem?

we should remove the loader indicator only when the isLoadingPrivateNotes is false meaning that the fetching process is finished

thus we can introduce this new variable:

            const isPrivateNotesFetchFinished = isPrivateNotesFetchTriggered && !report.isLoadingPrivateNotes;

and update the loader indicator to:

            const shouldShowFullScreenLoadingIndicator = !isPrivateNotesFetchFinished || (isPrivateNotesEmpty && (report.isLoadingPrivateNotes || !isOtherUserNote));

Result

Screen.Recording.2024-01-10.at.9.21.48.PM.mov

[thienlnam]

I don't think this needs to be a blocker - since the PR was merged recently, @hungvu193 and @jjcoffee can address

[jjcoffee]

@hungvu193 Are you able to look into this?

[abzokhattab]

Let me know what you think about the proposal above ... the PR can be ready once assigned.

[hungvu193]

@hungvu193 Are you able to look into this?

let me take a look

[melvin-bot]

@stitesExpensify Huh... This is 4 days overdue. Who can take care of this?

[stitesExpensify]

@hungvu193 any update?

[jjcoffee]

@hungvu193 Friendly bump! Did you get a chance to look at this?

[hungvu193]

@hungvu193 Friendly bump! Did you get a chance to look at this?

Sorry for late response, I'll draft a PR today.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Open offline notes from deeplink #34860

If no regressions arise, payment will be issued on 2024-02-07. 🎊

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

@stitesExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jjcoffee]

@stitesExpensify We're good to close this!

[stitesExpensify]

Great, Thanks!