Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request money - “Hmm… it’s not here” shown when adding a receipt to a manual request #34388

Closed
2 of 6 tasks
lanitochka17 opened this issue Jan 11, 2024 · 8 comments
Closed
2 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.24-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #32764

Action Performed:

  1. Go to any chat
  2. Request money with the scan tab and scan a receipt
  3. Request money again as manual request
  4. Go to the manual request
  5. Select the three dots on top right
  6. Add receipt

Expected Result:

The add receipt UI is shown and user can add a receipt after adding a manual expense

Actual Result:

After scanning a receipt seems that the new manual request isn't synced immediately and adding a receipt to it fails with the error message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6339213_1704997607887.az_recorder_20240111_182210.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 11, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 11, 2024

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@situchan
Copy link
Contributor

situchan commented Jan 11, 2024

I am not able to reproduce on main

@deetergp
Copy link
Contributor

I was unable to reproduce it in web. My Android environment is (unsurprisingly) being difficult, making it hard to test there. Either way, I don't feel like this warrants "Blocker" status. Anyone disagree?

@kavimuru
Copy link

kavimuru commented Jan 12, 2024

Still able to reproduce in Native app

Rpreplay.Final1705032101-1.mp4

@situchan
Copy link
Contributor

@kavimuru can you please confirm this doesn't happen on production?

@situchan
Copy link
Contributor

I think this is dupe of #34417

@Gonals Gonals removed the DeployBlockerCash This issue or pull request should block deployment label Jan 12, 2024
@Gonals
Copy link
Contributor

Gonals commented Jan 12, 2024

Agreed. Closing as duplicate!

@Gonals Gonals closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants