[$250] Chat - Green line and 'New' label disappear after clicking 'New Messages' and scrolling down

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.24-5
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Open App or go to staging.new.expensify.com
2. Login with any account
3. Go to any chat
4. Mark the latest message as unread
5. Scroll up the chat history
6. Click on 'New Messages' button

Expected Result:

Chat scrolls to the bottom. New message marked with green line and label 'New'.

Actual Result:

Green line and 'New' label disappear after clicking 'New Messages' and scrolling down

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• [x ] iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6339871_1705048686824.iOS-New-green-label-dissapear-after-press-button.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01583c5a710f37ccec
• Upwork Job ID: 1802797330742937527
• Last Price Increase: 2024-07-01

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[youssef-lr]

Checking. Not sure if this is a bug or a new fix.

[situchan]

reproduced in production as well.
Btw this is recent regression. Used to work before.
cc: @MonilBhavsar

[youssef-lr]

I'm not really sure this is a bug. It seems to also fix the 'New Messages' marker remaining even after we read the last unread message. @MonilBhavsar can you confirm please? Seems to be coming from this.

[youssef-lr]

I'm also able to reproduce this in production, removing blocker.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Green line and 'New' label disappear after clicking 'New Messages' and scrolling down

What is the root cause of that problem?

We are calling DeviceEventEmitter.emit(readNewestAction_${reportID}, lastReadTime) in readNewestAction util function which will mark the the latest latest unread report as read. We need to mark the the latest latest unread report as read but only when Mark as unread is clicked from context menu action.

App/src/libs/actions/Report.ts

Line 945 in a2864a0

DeviceEventEmitter.emit(`readNewestAction_${reportID}`, lastReadTime);

What changes do you think we should make in order to solve the problem?

We should call DeviceEventEmitter.emit(readNewestAction_${reportID}, lastReadTime); separately from readNewestAction action function because readNewestAction is used in multiple places. Or we can call it optionally inside readNewestAction by accepting a boolean prop.

Result

[zanyrenney]

also can reproduce!

[zanyrenney]

@MonilBhavsar are you able to take this one if its a regression from a previous release?

[MonilBhavsar]

Not sure if this is regression from #33162
@youssef-lr is this issue not reproducible without that code?

I have commented in other issue also #33118 (comment)

[situchan]

I can take this as C+

[zanyrenney]

thanks @situchan just waiting for a response @youssef-lr on if reproducbible without the code. thanks for the work looking into that @MonilBhavsar

[zanyrenney]

bump @youssef-lr please can you take a look?

[youssef-lr]

On it today @zanyrenney, sorry for the delay! I was OOO sick on Friday.

[melvin-bot]

@youssef-lr, @zanyrenney 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[youssef-lr]

Will take a look tomorrow @kbecciv

[zanyrenney]

Looking for new proposals here because it seems like it’s not behaving as it should based on the TestRail steps we have.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01583c5a710f37ccec

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[melvin-bot]

@youssef-lr, @zanyrenney, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[youssef-lr]

Waiting for proposals.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[zanyrenney]

@shubham1206agra @youssef-lr I think we should up the bounty for this one. What do you think?

[zanyrenney]

bump @shubham1206agra @youssef-lr

[melvin-bot]

@youssef-lr, @zanyrenney, @shubham1206agra 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[muttmuure]

This does not seem like a bug, so can we update Test Rail and move on please?

[melvin-bot]

@youssef-lr, @zanyrenney, @shubham1206agra 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@youssef-lr, @zanyrenney, @shubham1206agra 12 days overdue now... This issue's end is nigh!

[mvtglobally]

Issue not reproducible during KI retests. (First week)