Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Sign out - Page gets unresponsive after sign out when login with Abracadabra #34575

Closed
2 of 6 tasks
kbecciv opened this issue Jan 16, 2024 · 14 comments
Closed
2 of 6 tasks
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jan 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.25-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Enter email address and click Continue
  3. Navigate to the email and copy the login link
  4. Paste it to new tab and change to staging
  5. Navigate to the original tab and hit Sign out

Expected Result:

User should successfully sign out from New expensify page

Actual Result:

Page gets unresponsive after sign out when login with Abracadabra

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6344174_1705403674302.Recording__1822.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ff3aff1986d09d05
  • Upwork Job ID: 1747259844652462080
  • Last Price Increase: 2024-01-16
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jan 16, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 16, 2024

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mountiny
Copy link
Contributor

Can this be retested on the latest staging version please

@isagoico
Copy link

isagoico commented Jan 16, 2024

Still able to reproduce this issue in Web, build v1.4.25-6
image

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Jan 16, 2024
@melvin-bot melvin-bot bot changed the title Sign out - Page gets unresponsive after sign out when login with Abracadabra [$500] Sign out - Page gets unresponsive after sign out when login with Abracadabra Jan 16, 2024
Copy link

melvin-bot bot commented Jan 16, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01ff3aff1986d09d05

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 16, 2024
Copy link

melvin-bot bot commented Jan 16, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@ghost
Copy link

ghost commented Jan 16, 2024

I am getting this error on staging, when logging in using Abracadabra link and signout from staging.

Screenshot 2024-01-16 at 8 00 19 PM

@situchan
Copy link
Contributor

@AnshuAgarwal24 can you share console error?

@ghost
Copy link

ghost commented Jan 16, 2024

@AnshuAgarwal24 can you share console error?

These are the errors

Screenshot 2024-01-16 at 8 14 13 PM

@ikevin127
Copy link
Contributor

I cannot reproduce the issue, but there's some weird behaviour on my side like:

  • upon login, only 1-2 reports are showing in the LHN + report open avatars are not showing
  • upon signing out and being redirected to login page, focus mode gets activated and the modal appears
  • post-login loading times and overall fetching is very slow and also the Abracadabra page when link is opened
Weird behaviour video
Screen.Recording.2024-01-16.at.19.02.24.mov

@mountiny
Copy link
Contributor

mountiny commented Jan 16, 2024

Could we maybe try reverting the onyx bump and see if this behaviour gets better? #33554

@mountiny
Copy link
Contributor

I am trying a test build here and we can see if this is any better there #34596

@situchan
Copy link
Contributor

I suspect many similar deploy blockers came from Onyx. So worth trying revert

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Jan 16, 2024
@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Jan 17, 2024
@mountiny
Copy link
Contributor

QA confirmed the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants