-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-02-07] Focus mode modal can show incorrectly when signing up for a new account after logging out of an existing account. #34778
Comments
Job added to Upwork: https://www.upwork.com/jobs/~014e891ac070cbe788 |
Triggered auto assignment to @sophiepintoraetz ( |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane ( |
I'm guessing I'm here for the C+ payment of the review? |
Yes. I've got a PR in the works already. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-02-07. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@c3024 reviewed the associated PR. |
Triggered auto assignment to @bfitzexpensify ( |
Current assignee @bfitzexpensify is eligible for the Bug assigner, not assigning anyone new. |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Regression Test ProposalTests here are suitable regression tests.
👍 or 👎 |
@marcaaron, @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Regression steps look good, proposed they be added in https://github.com/Expensify/Expensify/issues/366901. Payment due on Wednesday. |
Payment summary: C+: @c3024 to be paid $500 via manual request. |
We're all done here, closing this one out. |
I'm not eligible for manual requests yet. I can only be paid on Upwork. @bfitzexpensify |
Gotcha - I've just made the Upwork job public, can you apply to it and let me know when you've done so? |
Thanks. Applied. Here is my Upwork profile as well for reference just in case if someone else has also applied. |
Thanks, all paid out - now we're done |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
Action Performed:
Expected Result:
We should only show this modal for users who have more than 30 chats.
Actual Result:
Saw [the focus mode] modal first (bad ❌)
This was a brand new account and I had only one chat.
Workaround:
👍
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: