Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-31] [HOLD for payment 2024-01-30] Android - IOU -In distance request, when user download receipt, app crashes. #34883

Closed
1 of 6 tasks
kbecciv opened this issue Jan 22, 2024 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jan 22, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.29.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4211240
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch app
  2. Tap on a Workspace chat
  3. Tap request money --- Distance
  4. Enter Start and finish waypoint
  5. Tap next
  6. Tap request
  7. Tap on newly created distance request to open distance request details page
  8. Tap on receipt
  9. Tap 3 dots on top right
  10. Tap download

Expected Result:

In distance request, when user download receipt, app must not crash.

Actual Result:

In distance request, when user download receipt, app crashes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6350049_1705914775745.dis.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jan 22, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Jan 22, 2024

We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify

@aimane-chnaif
Copy link
Contributor

This seems like upstream issue - RonRadtke/react-native-blob-util#321
Solution: RonRadtke/react-native-blob-util#321 (comment)
Came from #34633

@mountiny
Copy link
Contributor

cc @mkhutornyi @situchan are you able to loko into this one?

@mountiny
Copy link
Contributor

dont see any patch fix, so we might have to either revert or see if the downgrade of the package will help

@mkhutornyi
Copy link
Contributor

Strange. When I tested on branch, it worked fine. Now reproducible on main

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Jan 22, 2024
@situchan
Copy link
Contributor

I was not able to reproduce on #34633 either.

Copy link

melvin-bot bot commented Jan 22, 2024

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mountiny mountiny assigned mountiny and unassigned cristipaval Jan 22, 2024
@mountiny
Copy link
Contributor

CP ing the fix

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Jan 22, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 23, 2024
@melvin-bot melvin-bot bot changed the title Android - IOU -In distance request, when user download receipt, app crashes. [HOLD for payment 2024-01-30] Android - IOU -In distance request, when user download receipt, app crashes. Jan 23, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 23, 2024
Copy link

melvin-bot bot commented Jan 23, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 23, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.29-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-30. 🎊

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Jan 24, 2024
@melvin-bot melvin-bot bot added the Weekly KSv2 label Jan 24, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-01-30] Android - IOU -In distance request, when user download receipt, app crashes. [HOLD for payment 2024-01-31] [HOLD for payment 2024-01-30] Android - IOU -In distance request, when user download receipt, app crashes. Jan 24, 2024
Copy link

melvin-bot bot commented Jan 24, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.30-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-31. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants