[$500] Violation error messages are not shown on the expenses for admin account

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.30-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706024549828789

Action Performed:

1. Create a Collect policy on Newdot, if you do not have one already (steps here) and add at least one non-admin member
2. As a member (non-admin) of the workspace, create an expense with violations
3. Log in as a admin
4. Open the expense report created in step 2

Expected Result:

violation error messages appear

Actual Result:

No error message shown when login as admin

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1705.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01431218f64ad15b55
• Upwork Job ID: 1750036395342786560
• Last Price Increase: 2024-01-31

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01431218f64ad15b55

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[kameshwarnayak]

Unable to reproduce in the latest main

[puneetlath]

This happens to me consistently as the approver. Example reportID 563335175022642 from rocio@expensify.com. Transaction reportID 3206138938661089.

[melvin-bot]

@eVoloshchak, @stephanieelliott Huh... This is 4 days overdue. Who can take care of this?

[stephanieelliott]

Still waiting for proposals for this

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[stephanieelliott]

Posted in #expensify-swm to see if we can get an expert contrib to jump on this, since it's affecting us internally. https://expensify.slack.com/archives/C04878MDF34/p1706741963165049

[SzymczakJ]

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

[SzymczakJ]

I lack information to reproduce this bug. I tried creating Workspace on new-dot but these workspaces don't have tag section. Additionally Category section seems to be not required because it doesn't show 'Missing category" error. How to create a workspace that has a required tag section and has a required category section? Below the screenshot of expense from workspace I created.

Can somebody make reproduction steps clearer 😁 ?

[stephanieelliott]

Ah @SzymczakJ the Category and Tag features are only present on Collect workspaces, and not on free workspaces (which is what you created).

I'll update the repro steps, but also adding the steps to create the Collect workspace here too. If you run into problems, let me know the email you're using and name of the test workspace so I can try and help!

1. Create a collect policy in OldDot
2. Execute the following JS snippet in the OldDot policy to enable workspace chats creation:
   if (Url.getCurrentPageName()!="policy" ){ alert('Only run this snippet from a policy editor!'); } else { var p = Policy.getCurrent(); p.policy.isPolicyExpenseChatEnabled = "true"; p.save().done(function(){$.jGrowl('Workspace chat creation enabled!')}); }

[SzymczakJ]

Great, I managed to reproduce the bug and I'm working to fix it. For now, we don't get violations info from backend as admin, but I think it's front end related.

[SzymczakJ]

@stephanieelliott after some research I've found that every update of "request money"(for example change of tag) is triggering a Pusher update that gives new data to UI. All data (transaction data, report data, reportActions data, etc.) is sent through pusher except of transactionViolations data which is responsible for showing violation errors, and that's why we have bugs like this one. I don't have much knowledge about how Pusher works on backend, so I might be mistaken but I think that making Pusher send transactionViolation data when it changes on the backend would solve this issue.
It might be also on frontend side(not setting proper fields) but please check if transactionViolations data is sent properly through the pusher.

[puneetlath]

cc @cead22 on the above.

[cead22]

Yeah we need to send transaction violations to clients from backend commands like UpdateMoneyRequestAmountAndCurrency, which I have an issue for

[SzymczakJ]

@cead22 could you notify me when transaction violations issue is completed? Then I would check if it solves this bug completely

[melvin-bot]

@eVoloshchak @stephanieelliott @SzymczakJ this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[stephanieelliott]

Bump @cead22, could you share that transaction violations issue here? Thinking we'll want to hold on that to see if the fix resolves this issue

[cead22]

The issue is here https://github.com/Expensify/Expensify/issues/361948. I think we can close this issue since we have that one, and the problem in the description of this issue isn't accurate, since violations show for employees, not admins