Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect admin - New invited user appears four times in workspace chat member list #35407

Closed
4 of 6 tasks
lanitochka17 opened this issue Jan 30, 2024 · 9 comments
Closed
4 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.33-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4254707
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. On Old Dot, create a Collect workspace and add this snippet to console.
if (Url.getCurrentPageName()!="policy" ){ alert('Only run this snippet from a policy editor!'); } else { var p = Policy.getCurrent(); p.policy.isPolicyExpenseChatEnabled = "true"; p.save().done(function(){$.jGrowl('Workspace chat creation enabled!')}); }
  1. Log in to New Dot (log out and log in again if logged in to see the Collect workspace in New Dot settings).
  2. Go to Settings > Workspaces > Collect workspace > Members
  3. Invite a new member who is not registered on New Dot
  4. Go to workspace chat with the new member
  5. Click on the chat header
  6. Click Members

Expected Result:

The new member only appears one time in the member list

Actual Result:

The new member appears four times in the member list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6360974_1706626042698.bandicam_2024-01-30_21-52-09-931.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 30, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 30, 2024

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave8.
CC @zanyrenney

@arosiclair
Copy link
Contributor

Can't reproduce on web v1.4.33-4

Screenshot 2024-01-30 at 11 01 13 AM

@arosiclair
Copy link
Contributor

Tried twice with private (expensifail.com) and public (gmail.com) domains and did not reproduce.

Screen.Recording.2024-01-30.at.11.04.04.AM.mov

Closing this out

@kbecciv
Copy link

kbecciv commented Jan 30, 2024

The issue is reproducible consistently for the QA team. Please attach the video. @arosiclair You need to open member list right after inviting the new user.

20240131_030930.mp4

Screenshot 2024-01-31 at 03 14 04

@kbecciv kbecciv reopened this Jan 30, 2024
@francoisl
Copy link
Contributor

Hmm yeah I can't repro either. The workspace chat doesn't appear unread in my LHN after inviting the user though, but I think that's from a different issue.

Screen.Recording.2024-01-30.at.12.42.28.PM.mov

Looks like it might be an issue with optimistic data and the members list is correct once the API returns the updated chat members list? Either way, doesn't look like it's blocking any major workflow so we can remove the label for now.

@francoisl francoisl added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 30, 2024
@arosiclair
Copy link
Contributor

@kbecciv @lanitochka17 there seems to be something missing from the reproduction steps. Please update them otherwise we'll just close this as it is not reproducible currently.

@melvin-bot melvin-bot bot added the Overdue label Feb 2, 2024
@arosiclair
Copy link
Contributor

No update. Closing this out again

@melvin-bot melvin-bot bot removed the Overdue label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants