Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag - Inconsistency in tag custom name for "Missing tag" and "Tag no longer valid" #35425

Closed
6 tasks done
lanitochka17 opened this issue Jan 30, 2024 · 4 comments
Closed
6 tasks done
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.33-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4253774
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

  • Admin and employee are part of Collect workspace
  • The Collect workspace has tags and Tag has custom name
  1. [Employee] Create a manual request with a tag in the workspace chat
  2. [Admin] Disable the tag in Step 1
  3. [Employee] Navigate to request details page
  4. [Employee] Note that it shows "<custom_tag_name> no longer valid"
  5. [Employee] Create another manual request with no tag
  6. [Employee] Navigate to request details page

Expected Result:

The violation will show "Missing <custom_tag_name>"

Actual Result:

The violation will show "Missing tag". There is inconsistency in the behavior between "Missing tag" and "Tag no longer valid"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6361204_1706638199326.20240131_001149.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 30, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 30, 2024

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave.
CC @zanyrenney

@yuwenmemon
Copy link
Contributor

This looks like expected behavior. Not a blocker. Closing!

@yuwenmemon yuwenmemon removed the DeployBlockerCash This issue or pull request should block deployment label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants