Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEDIUM] Feature Request: Make attachments to show immediately like the regular messages #35819

Closed
6 tasks done
m-natarajan opened this issue Feb 5, 2024 · 2 comments
Closed
6 tasks done
Assignees
Labels
NewFeature Something to build that is a new item. Weekly KSv2

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707112380464339

Problem:

If I post a message like "Hello world", it'll appear exactly as if I had already sent it -- even if in fact it's still uploading it. It will also show grayed out if I'm offline, to indicate it hasn't sent. But we treat attachments differently: we show a static Uploading attachment... message, which is replaced with the preview after upload. I'm not even sure if it works offline, or what it shows while it's queued for offline upload.

Solution:

Let's make attachments work like regular posts in that we should show the attachment immediately in its final location, exactly as if it uploaded instantly. If we are offline and it hasn't yet uploaded, then show the preview grayed out.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

@m-natarajan m-natarajan added Weekly KSv2 NewFeature Something to build that is a new item. labels Feb 5, 2024
Copy link

melvin-bot bot commented Feb 5, 2024

@trjExpensify
Copy link
Contributor

Going to close this as a dupe, as we're working on making this a reality already. From the long list of dependencies, there's this one to support image caching: #12603

Unfortunately, the latest PR for it was deployed and then reverted on Friday last week. So we need to revisit that with @kidroca to fix and redeploy.

After which, we can get back to implementing a solution for this feature request here. I've put that issue in #vip-vsb as a medium to track. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants