Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS - Tapping Download on “Share code” doesn’t always work #35919

Closed
1 of 6 tasks
kbecciv opened this issue Feb 6, 2024 · 10 comments
Closed
1 of 6 tasks

IOS - Tapping Download on “Share code” doesn’t always work #35919

kbecciv opened this issue Feb 6, 2024 · 10 comments
Assignees
Labels
Engineering Monthly KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Feb 6, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.37-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #34580

Action Performed:

  1. Launch the app and tap on the avatar on top right
  2. Tap on Share code > Download

Expected Result:

An image is downloaded with the QR code

Actual Result:

Most of the times nothing happens. If the Download icon is tapped several times rarely it does work

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6369530_1707237363603.RPReplay_Final1707229352.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 6, 2024

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Feb 6, 2024

We think that this bug might be related #vip-vsb
CC @quinthar

@allgandalf
Copy link
Contributor

regression from :

#34580

@situchan
Copy link
Contributor

situchan commented Feb 6, 2024

Commented with the solution in offending PR

@allgandalf
Copy link
Contributor

If this becomes external, I would be willing to fix the issue :)

@filip-solecki filip-solecki mentioned this issue Feb 6, 2024
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Feb 6, 2024
@marcaaron
Copy link
Contributor

marcaaron commented Feb 6, 2024

@thienlnam do we need to CP this one to staging?

@thienlnam
Copy link
Contributor

Ah I didn't realize this was linked to a blocker - yeah I can get this CPed sorry

@thienlnam thienlnam assigned thienlnam and unassigned arosiclair Feb 6, 2024
@marcaaron marcaaron removed the DeployBlockerCash This issue or pull request should block deployment label Feb 7, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Mar 1, 2024
Copy link

melvin-bot bot commented Mar 1, 2024

This issue has not been updated in over 15 days. @thienlnam eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@thienlnam
Copy link
Contributor

Closing - this was a regression that was fixed by the original author / reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants