[HOLD for payment 2024-03-26] [$500] [New architecture] Replace @oguzhnatly/react-native-image-manipulator with expo-image-manipulator

[j-piasecki]

Name of library: expo-image-manipulator

More context: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293299589539
Discussion here: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293319626329

Details

• Link to package: https://www.npmjs.com/package/expo-image-manipulator
• Problem solved by using this package: The library we're using now (@oguzhnatly/react-native-image-manipulator) is a transitive fork of expo-image-manipulator. The original package is more actively maintained and uses expo-modules-core so it should support both, the new and the old architecture.
• Number of stars in GH: 26.7k
• Number of monthly downloads: 42,954
• Number of releases in the last year: 9
• Level of activity in the repo: high
• Alternatives: @oguzhnatly/react-native-image-manipulator or any of the other expo-free forks of this library.
• Are security concerns brought up and addressed in the library's repo?
• How many dependencies does this lib use that will be brought into our code?

0 – since we already have the Expo modules core.

• What will the effect be on the bundle size of our code?

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f064b153d795f898
• Upwork Job ID: 1766142757478912000
• Last Price Increase: 2024-03-08

[melvin-bot]

Triggered auto assignment to @mountiny (AutoAssignerAppLibraryReview), see https://stackoverflowteams.com/c/expensify/questions/17737 for more details.

[melvin-bot]

New Library Review

• Are all the answers in the main description filled out properly and make sense?
• Who maintains the library and how well is it maintained?
• How viable are the alternatives?
• Should we build it ourselves instead?

Once these questions are answered, start a thread in #engineering-chat, ping the @app_deployers group, and call for a vote to accept the new library. Once the vote is complete, update this issue with the outcome and procede accordingly. Here is a sample post:

Hey @app_deployers,

There is a request to add a new library to App that we need to consider. Please look at this GH and then vote :+1: or :-1: on accepting this new library or not.

GH_LINK

[kowczarz]

Hey! I'm Kamil from Software Mansion and I would like to work on this task.

[roryabraham]

@mountiny for some context, we did get New Arch support merged for the fork we're currently using, but it has not yet been published to npm. It took about a year for the PR to be reviewed.

The main reason I support this switch is because we're already using a fork of expo-image-manipulator, so using the original source and the most widely adopted version of this library makes sense.

[kowczarz]

What will the effect be on the bundle size of our code?

According to https://bundlephobia.com we will add ~2kB (added ~2.5kB removed ~250B), but since @oguzhnatly/react-native-image-manipulator is based on expo-image-manipulator it seems it's a bug in the tool and the bundle size shouldn't be affected that much.

[mountiny]

I will do this tomorrow

[mountiny]

Posted here https://expensify.slack.com/archives/C01GTK53T8Q/p1707496462582779

[jeremy-croff]

I traced back the reason for using this fork to help determine my decisions and found it here:
#6301 (comment)

Not having expo at the time was the main reason for using the fork, and because we now have it, it totally makes sense to use the original package.

[roryabraham]

Want to clarify with whatever C+ gets assigned to this issue that we'll pay a $250 bounty for the review instead of the standard $500

[mountiny]

We have got I believe 6 or 7 👍 from App deployers across GH and Slack and 0 pushback so we can go ahead with the PR @kowczarz

[mountiny]

Asked for an update on the PR

[muttmuure]

On staging

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [New architecture] Replace @oguzhnatly/react-native-image-manipulator with expo-image-manipulator #36019

If no regressions arise, payment will be issued on 2024-03-14. 🎊

For reference, here are some details about the assignees on this issue:

• @kowczarz does not require payment (Contractor)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[laurenreidexpensify]

Payment Summary:

Contributor: @kowczarz no payment, agency contributor
C+ Review: @mananjadhav $500 please request in newdot

[mananjadhav]

@laurenreidexpensify this issue is not closed. The earlier PR was reverted, and the new one is under review right now. Can you please remove the payout summary and reopen the issue?

[mountiny]

this was reverted so reopening

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [New architecture] Replace @oguzhnatly/react-native-image-manipulator with expo-image-manipulator [v2] #38145

If no regressions arise, payment will be issued on 2024-03-26. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @hungvu193 requires payment (Needs manual offer from BZ)
• @kowczarz does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav / @hungvu193] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[laurenreidexpensify]

Payment Summary:

Contributor: @kowczarz no payment, agency contributor
C+ Review: @mananjadhav $500 please request in newdot

@hungvu193 pls apply for payment in upwork - https://www.upwork.com/jobs/~0155bf7bf36c1319ef

[hungvu193]

Payment Summary:

Contributor: @kowczarz no payment, agency contributor

C+ Review: @mananjadhav $500 please request in newdot

@hungvu193 pls apply for payment in upwork - https://www.upwork.com/jobs/~0155bf7bf36c1319ef

I've just applied!

[PierreAdel]

Upwork Proposal: Upgrading React Native Image Manipulator Package

Dear Team,

To address the issue with the current library, I propose upgrading to the original package, expo-image-manipulator, which is more actively maintained and supports both the new and old architecture. By transitioning to this package, we ensure compatibility with Expo modules core and benefit from ongoing updates and enhancements.

Implementation Plan:

1. Assessment: Evaluate the current usage of @oguzhnatly/react-native-image-manipulator in our application and identify any potential dependencies or conflicts.
2. Migration: Replace the existing library with expo-image-manipulator in our codebase, ensuring compatibility with both the old and new architecture.
3. Testing: Conduct thorough testing to validate the functionality and performance of the image manipulation features with the new library.
4. Deployment: Once testing is successful, deploy the updated version of the application to production, ensuring a seamless transition for end-users.

Looking forward to it.

Contributor details
Your Expensify account email: pierre@expensify.com
Upwork Profile Link: https://www.upwork.com/freelancers/pierreadel2

[melvin-bot]

📣 @PierreAdel! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[JmillsExpensify]

$500 approved for @mananjadhav based on summary.