Chat - Preview shows | > | > | when adding multiple > in the composer

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4-39-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Type >>>>> in the composer

Expected Result:

The composer displays | >>> (Android and iOS app behavior)

1. Limit max depth of the quote inside ExpensiMark
2. change implementation of blockquotes in chat to show multi-level quotes
3. Enable inside react-native-live-markdown library support for multilevel quotes on all platforms - here won't be any limit, as parser should handle it.

Discussion for expected result https://expensify.slack.com/archives/C01GTK53T8Q/p1707904106957409

Actual Result:

The composer shows | > | > | instead of | >>>>>

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6373593_1707485081273.bandicam_2024-02-09_13-06-26-947__1_.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @lakchote (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[shubham1206agra]

@thienlnam @tomekzaw I think we jumped the gun here as we don't support multi-level blockquote yet. I think we need to implement these in ExpensiMark.

[lakchote]

Offending PR found. This is the one related to markdown preview.

cc @shubham1206agra @tomekzaw @thienlnam

[tomekzaw]

Thanks for reporting this, we will decide on the expected behavior here and implement it. Please assign me

[thienlnam]

We've reverted the offending PR #35837, so this is no longer a blocker

[thienlnam]

Discussion for expected outcome here: https://expensify.slack.com/archives/C01GTK53T8Q/p1707904106957409
The new plan from @robertKozik:

1. Limit max depth of the quote inside ExpensiMark
2. change implementation of blockquotes in chat to show multi-level quotes
3. Enable inside react-native-live-markdown library support for multilevel quotes on all platforms - here won't be any limit, as parser should handle it.

[robertKozik]

Hi! Small update on my end.
I've managed to create draft PR with ExpensiMark changes (Here: Expensify/expensify-common#654) I've come across the undiscovered issue, that parser was removing one excess > every time - it slowed me down a little, but I've managed to fix it as well.

Now I'm on adjusting react-native-live-markdown, as I think should be merged before, and after them we should update E/App

[robertKozik]

The support for multiple quotes has already been merged into the react-native-live-markdown library.

The PR within expensify-common is ready for review, and once merged, it will be the final piece needed to fully support nested quotes.

[lakchote]

Any update @robertKozik? The PR in expensify-common has been merged.

[thienlnam]

Bump on this - looks like we just need to bump a version or something?

[robertKozik]

Yeah, sorry for my absence in this thread. New version of the expensify-common is already merged in the live-markdown library. Version bump for E/App will take place inside the PR with new version of react-native-live-markdown for the App

[bernhardoj]

Hi, I have a live markdown PR here to fix this app issue and I notice that the current version of live markdown in app is 0.1.5, but the latest version of live markdown is 0.1.28.

@robertKozik I don't see the App PR yet, so just want to confirm, is your App PR will update the live markdown version to 0.1.28?

(our plan is to wait for the live markdown version to be updated to 0.1.28 and then I will separately create another PR to update it further to include my live markdown PR above. I was thinking to ask for your help to include my live markdown PR above, but I think it would be out of scope)

[BartoszGrajdek]

@thienlnam I believe this is now fixed 🤔 There's still #38199 but that's a separate issue

[BartoszGrajdek]

Okay I tested it and it still requires some more investigation, so let's keep this issue for now

[BartoszGrajdek]

This seems to not be a problem anymore @thienlnam can we get someone to test it again? 🤔

[kavimuru]

@thienlnam Issue is fixed.

2024-04-03.20-07-42.mp4

[thienlnam]

We're good, thanks!