[ON HOLD #34610] [$500] Distance - Duplicate waypoints message does not instantly show up in distance request editor #36519

kbecciv · 2024-02-14T15:56:40Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.41-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Go to workspace chat.
Go to + > Request money > Distance.
Enter A-B-A waypoints.
Reorder the waypoints by dragging so that it becomes A-A-B.
Note that error message for duplicate waypoints instantly shows up.
Change the distance back to A-B-A.
Proceed to confirmation page.
Click Distance.
Reorder the waypoints by dragging so that it becomes A-A-B.
Note that error message for duplicate waypoints instantly shows up.
Create the distance request with A-B-A waypoints.
Go to request details page.
Click Distance.
Reorder the waypoints by dragging so that it becomes A-A-B.

Expected Result:

The error message for duplicate waypoints will instantly show up.

Actual Result:

The error message for duplicate waypoints does not instantly show up. It only shows up after user attempts to save the duplicate waypoints.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6379526_1707925145578.20240214_195943.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b6febd25fc272874
Upwork Job ID: 1757796016628969472
Last Price Increase: 2024-08-07

melvin-bot · 2024-02-14T15:56:45Z

Job added to Upwork: https://www.upwork.com/jobs/~01b6febd25fc272874

melvin-bot · 2024-02-14T15:56:50Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

melvin-bot · 2024-02-14T15:56:53Z

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

kbecciv · 2024-02-14T15:57:11Z

We think that this bug might be related #wave5-free-submitters
CC @dylanexpensify

paultsimura · 2024-02-14T16:08:17Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

When editing a Distance request, the duplicate waypoints error is not shown immediately.

What is the root cause of that problem?

When implementing this immediate error display, it was added only for the creation flow: #32999, and the edit flow was missed.

What changes do you think we should make in order to solve the problem?

We need to add the same changes (made in #32999 to IOURequestStepDistance) to the DistanceRequest/index.js, which is used on the edit flow.

As a side note, we should also add the !isEditingRequest as a third param here to merge the correct collection (non-draft transactions for the Edit flow) when updating the waypoints:

Transaction.updateWaypoints(transactionID, newWaypoints, !isEditingRequest)

App/src/components/DistanceRequest/index.js

Lines 203 to 205 in 6ed3706

    
           Transaction.updateWaypoints(transactionID, newWaypoints).then(() => { 
        
               setOptimisticWaypoints(null); 
        
           });

What alternative solutions did you explore? (Optional)

s77rt · 2024-02-14T22:49:57Z

I think DistanceRequest should / will be removed in #34610

@zanyrenney Can you please put this on hold for #34610

zanyrenney · 2024-02-19T15:17:00Z

DONE, thanks!

zanyrenney · 2024-02-21T15:55:50Z

This is on HOLD. so Not a daily priority just now.

zanyrenney · 2024-02-21T15:57:40Z

Not overdue, on hold.

melvin-bot · 2024-02-21T16:00:19Z