Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [Performance] Limit getReportName to first 5 participants #37925

Closed
muttmuure opened this issue Mar 7, 2024 · 10 comments
Closed

[$250] [Performance] Limit getReportName to first 5 participants #37925

muttmuure opened this issue Mar 7, 2024 · 10 comments
Assignees
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@muttmuure
Copy link
Contributor

muttmuure commented Mar 7, 2024

Problem:

In some cases, when the number of participants is big, we were needlessly calculating getDisplayNameForParticipant where in the end, we wouldn't be able to display it since the output is trimmed afterwards anyways.

Solution

The number of participants used to determine the Report name via getReportName is limited to first 5 participants other than current user.

This change allows to cap the performance impact of getReportName (which is used within getOrderedReportIDs)

from here: https://expensify.slack.com/archives/C05LX9D6E07/p1709831181822099

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bcaa1758a6b23688
  • Upwork Job ID: 1766057020696662016
  • Last Price Increase: 2024-03-08
@muttmuure muttmuure changed the title Limit getReportName to first 5 participants [Performance] Limit getReportName to first 5 participants Mar 7, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 labels Mar 8, 2024
@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Mar 8, 2024
Copy link

melvin-bot bot commented Mar 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01bcaa1758a6b23688

@melvin-bot melvin-bot bot changed the title [Performance] Limit getReportName to first 5 participants [$500] [Performance] Limit getReportName to first 5 participants Mar 8, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 8, 2024
Copy link

melvin-bot bot commented Mar 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Mar 8, 2024
@mountiny mountiny changed the title [$500] [Performance] Limit getReportName to first 5 participants [$250] [Performance] Limit getReportName to first 5 participants Mar 8, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Mar 8, 2024
Copy link

melvin-bot bot commented Mar 8, 2024

Upwork job price has been updated to $250

@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 8, 2024
@rayane-djouah

This comment was marked as resolved.

Copy link

melvin-bot bot commented Mar 15, 2024

@deetergp, @mollfpr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Mar 19, 2024

@deetergp, @mollfpr Still overdue 6 days?! Let's take care of this!

@deetergp deetergp removed the Reviewing Has a PR in review label Mar 19, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 19, 2024
@deetergp
Copy link
Contributor

I think we can close this one, since it appears the actual limiting of the names is being done on #38052. A PR for it is currently under review: #38568.

@melvin-bot melvin-bot bot removed the Overdue label Mar 19, 2024
@deetergp
Copy link
Contributor

@muttmuure I think we owe @mollfpr for review of #37907 before we can close this out.

@mollfpr
Copy link
Contributor

mollfpr commented Mar 22, 2024

@deetergp I think I'll request the compensation here #38009. We can close this.

@deetergp
Copy link
Contributor

Okay @mollfpr, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Development

No branches or pull requests

5 participants