-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] [Performance] Limit getReportName to first 5 participants #37925
Comments
muttmuure
changed the title
Limit getReportName to first 5 participants
[Performance] Limit getReportName to first 5 participants
Mar 7, 2024
50 tasks
mountiny
added
the
External
Added to denote the issue can be worked on by a contributor
label
Mar 8, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01bcaa1758a6b23688 |
melvin-bot
bot
changed the title
[Performance] Limit getReportName to first 5 participants
[$500] [Performance] Limit getReportName to first 5 participants
Mar 8, 2024
melvin-bot
bot
added
the
Help Wanted
Apply this label when an issue is open to proposals by contributors
label
Mar 8, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
mountiny
changed the title
[$500] [Performance] Limit getReportName to first 5 participants
[$250] [Performance] Limit getReportName to first 5 participants
Mar 8, 2024
Upwork job price has been updated to $250 |
mountiny
removed
the
Help Wanted
Apply this label when an issue is open to proposals by contributors
label
Mar 8, 2024
This comment was marked as resolved.
This comment was marked as resolved.
@muttmuure I think we owe @mollfpr for review of #37907 before we can close this out. |
Okay @mollfpr, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem:
In some cases, when the number of participants is big, we were needlessly calculating getDisplayNameForParticipant where in the end, we wouldn't be able to display it since the output is trimmed afterwards anyways.
Solution
The number of participants used to determine the Report name via getReportName is limited to first 5 participants other than current user.
This change allows to cap the performance impact of getReportName (which is used within getOrderedReportIDs)
from here: https://expensify.slack.com/archives/C05LX9D6E07/p1709831181822099
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: