[Profile] Web - Joined workspace which is pending for approval disappears after relogin

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.49.0
Reproducible in staging?: y
Reproducible in production?: new feature
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• The invite link to workspace is https://staging.new.expensify.com/settings/workspaces/<Workspace_ID>/join?email=<admin_email>
  Example: https://staging.new.expensify.com/settings/workspaces/51C70B8D97474AA5/join?email=applausetester+kh070307@applause.expensifail.com

1. [Employee] Click on the invite to join the workspace.
2. [Employee] After the workspace shows up in All workspaces page, log out.
3. [Employee] Log in again and go to All workspaces page.

Expected Result:

Joined workspace which is pending for approval should be visible after relogin

Actual Result:

Joined workspace which is pending for approval disappears after relogin

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

20240308_175601.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010b6b769a86dd06b0
• Upwork Job ID: 1767247956971724800
• Last Price Increase: 2024-03-11

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[dragnoir]

Can't reproduce. I think it's a BE and already fixed.

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mountiny]

This is a new feature and currently not used by the customers in NewDot so not a blocker cc @luacmartins

[luacmartins]

This seems like a backend issue too. We're probably not sending the policy data for non-member back to the user on OpenApp.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010b6b769a86dd06b0

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @allroundexperts (Internal)

[luacmartins]

I'm gonna add the Hot Pick label here. @tgolen feel free to remove it if you wanna take this on.

[kevinksullivan]

No update, in hot picks waiitng for a volunteer.

[amyevans]

I tried to reproduce this bug but I am hitting the Not Found page when visiting a /workspace/<Workspace_ID>/join?email=<admin_email> link:

Screen.Recording.2024-03-18.at.3.14.38.PM.mov

I tried on staging in addition to locally and same Not Found result. Any ideas on what's up @luacmartins?

[luacmartins]

@amyevans we renamed those routes in Ideal Nav v2, so the correct url is /settings/workspaces/<policyID>/join?email=<inviterEmail>. I updated the OP to reflect that.

[melvin-bot]

@kevinksullivan, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

It seems like the issue comes from the API not sending data for the join requests.

[luacmartins]

Hmm I think the solution for this one might be a bit involved, since we currently only store the join requests in the policy object, so we'd have to query all policies in the DB to find which ones have a join request from a particular user 😅 I think we'd have to solve this by:

1. Create a new NVP nvp_joinRequests, which stores an array of policyIDs that the user has requested access to
2. In OpenApp, check for any policyIDs stored in nvp_joinRequests and return the non-member data
3. In JoinViaInviteLink, save the policyID to the nvp_joinRequests NVP
4. In AcceptJoinRequest/DeclineJoinRequest, remove the policyID from the NVP

[luacmartins]

I'll work on this one

[luacmartins]

Discussing here

[luacmartins]

As discussed in the thread above, we decided to :do-nothing: given that we:

1. Don't display anything to users in OldDot besides the growl
2. Users never asked us for this feature
3. Low usage of this flow
4. We currently show the pending requests, but users would have to log out / in to not see it again

Feel free to reopen if you feel differently.