[HOLD for payment 2024-03-22] [$500] Authorized payer - Enter key does not select another member as authorized payer

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.51-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

• User is an owner of Collect workspace.
• There is at least another admin in the workspace.

1. Go to staging.new.expensify.com.
2. Go to workspace settings > Collect workspace.
3. Go to Workflows.
4. Enable Make or track payments if not enabled.
5. Click Authorized payer.
6. Navigate to another admin via keyboard and hit Enter.

Expected Result:

Enter key will select another admin as the authorized payer.

Actual Result:

Enter key is not responsive when the selection is on another admin.
When the selection is on the authorized payer, Enter key exits the RHP.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6411925_1710308620444.bandicam_2024-03-13_13-39-04-261.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cb6806f250da1d85
• Upwork Job ID: 1767835771147452416
• Last Price Increase: 2024-03-13
• Automatic offers:
• jjcoffee | Contributor | 0
• ishpaul777 | Contributor | 0

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kavimuru]

@Beamanator FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cb6806f250da1d85

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[Beamanator]

This does look like it can be worked externally 👍 And it doesn't look like a big enough problem to be a deploy blocker - i bet this is a newer feature where we didn't build in the "Select with enter key"?

[Beamanator]

Ya looks like it was built here: #37629

[Beamanator]

@luacmartins @shawnborton @ishpaul777 @jjcoffee can y'all help decide if we want to build this as a follow-up to the PR that just got to staging, or if we think this can be worked separately, in this issue, by another contrib?

[ishpaul777]

Thanks for tagging. I'll raise a quick fixing PR @Beamanator

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fixes enter click to select the authorized payer #38221

If no regressions arise, payment will be issued on 2024-03-22. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee]] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jjcoffee]

@lschurr Can you assign me here as I was the C+ for the PR? Thanks! 🙏

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[lschurr]

Could you work through the checklist on this one @jjcoffee?

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: feat: Workflow payer page #37629
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/37629/files#r1531725204
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to Workspace settings > Collect workspace.
2. Go to Workflows.
3. Enable Make or track payments if not enabled.
4. Click Authorized payer.
5. Navigate to another admin via keyboard and hit Enter, verify currect user is Selected as authoirized payer

Do we agree 👍 or 👎

[luacmartins]

We'll add regression steps once this feature is fully implemented.

[jjcoffee]

@lschurr Friendly bump for payment! 🙇

[lschurr]

All set! Payment for $500 sent via Upwork to @jjcoffee

[ishpaul777]

Actually this was a follow up PR, is this eligible for payment @luacmartins

[lschurr]

Ah it looks like this GH wasn't assigned to you so that's why the offer didn't go out @ishpaul777

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[lschurr]

Payment summary:

• Contributor: @ishpaul777 $500 (paid in Upwork)
• Contributor+: @jjcoffee $500 (paid in Upwork)

[ishpaul777]

Thank you!