[HOLD for payment 2024-03-26] [Wave Collect] [Ideal Nav] Chats - Only deleted workspace chats are shown in Chats after deleting the workspace

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Found when validating PR : #37421

Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com.
2. Click on the workspace switcher > Add a workspace icon.
3. Return to chat.
4. Click on the workspace switcher > Select workspace created in Step 2.
5. Go to Settings > Workspaces.
6. Delete the workspace in Step 2.
7. Return to chat.

Expected Result:

All the chats will be displayed since the workspace switcher is Expensify (all chats).

Actual Result:

Only the chats under the deleted workspace are displayed when the workspace switcher is Expensify.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6412960_1710377464684.bandicam_2024-03-14_08-45-35-732.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @anmurali

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @grgia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@grgia I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to #wave-collect - Release 1
CC @trjExpensify

[mountiny]

I can take over, most likely related to the ideal nav PR. I think it does not have to be a blocker, user can get all the chats by selecting All workspaces

[mountiny]

The behaviour in this case changes to what we had in the past.

Firstly, seeing the policy settings does not mean we select that workspace as active. Hence, user can have a Workspace A selected in the workspace switcher and be in Workspace B settings. When they delete Workspace B, nothing needs to change.

However, if they have Workspace B selected as the active workspace in regards to the Workspace switcher, then if they delete the Workspace B, we need to make sure the active workspace is reset. Because then they come to the chats sections and they only see chats of the deleted workspace, which no longer can be selected in the workspace switcher.

---

The solutions is that in both WorkspacesListPage and WorkspaceProfilePage when the policy is being deleted, we need to check if its the same policy as the one selected in the switcher. If it is, reset that settings to All workspaces.

[mountiny]

@ishpaul777 will handle this one

[trjExpensify]

However, if they have Workspace B selected as the active workspace in regards to the Workspace switcher, then if they delete the Workspace B, we need to make sure the active workspace is reset. Because then they come to the chats sections and they only see chats of the deleted workspace, which no longer can be selected in the workspace switcher.

Makes sense, let's reset it in this case 👍

[melvin-bot]

Current assignees @jjcoffee and @ishpaul777 are eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• switch to all workspace view when workspace is deleted #38365

If no regressions arise, payment will be issued on 2024-03-26. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment (Needs manual offer from BZ)
• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee / @ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee / @ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee / @ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee / @ishpaul777] Determine if we should create a regression test for this bug.
• [@jjcoffee / @ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: Ideal nav v2 workspaces #37421
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Ideal nav v2 workspaces #37421 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - big PR, so naturally some things got missed
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Click on the workspace switcher > Add a workspace icon.
2. Return to chat.
3. Click on the workspace switcher > Select workspace created in Step 2.
4. Go to Settings > Workspaces.
5. Delete the workspace in Step 2.
6. Return to chat.
7. Verify all workspaces chat are visible, and Expensify is selected in workspace switcher

Do we agree 👍 or 👎

[jjcoffee]

@anmurali Friendly bump for payment 🙇

[mountiny]

I think this is a good test to Add to testrail

[anmurali]

@ishpaul777 - offer
@jjcoffee - offer

[jjcoffee]

@anmurali Accepted, thanks!

[ishpaul777]

Offer accepted Thanks!

[jjcoffee]

@anmurali Friendly bump to complete the payment 🙇

[melvin-bot]

@anmurali, @jjcoffee, @mountiny, @ishpaul777 Huh... This is 4 days overdue. Who can take care of this?

[anmurali]

Both paid!