-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-03-26] [Wave Collect] [Ideal Nav] Chats - Only deleted workspace chats are shown in Chats after deleting the workspace #38277
Comments
Triggered auto assignment to @anmurali ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @grgia ( |
@grgia I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
We think that this bug might be related to #wave-collect - Release 1 |
I can take over, most likely related to the ideal nav PR. I think it does not have to be a blocker, user can get all the chats by selecting All workspaces |
The behaviour in this case changes to what we had in the past. Firstly, seeing the policy settings does not mean we select that workspace as active. Hence, user can have a Workspace A selected in the workspace switcher and be in Workspace B settings. When they delete Workspace B, nothing needs to change. However, if they have Workspace B selected as the active workspace in regards to the Workspace switcher, then if they delete the Workspace B, we need to make sure the active workspace is reset. Because then they come to the chats sections and they only see chats of the deleted workspace, which no longer can be selected in the workspace switcher. The solutions is that in both WorkspacesListPage and WorkspaceProfilePage when the policy is being deleted, we need to check if its the same policy as the one selected in the switcher. If it is, reset that settings to All workspaces. |
@ishpaul777 will handle this one |
Makes sense, let's reset it in this case 👍 |
Current assignees @jjcoffee and @ishpaul777 are eligible for the External assigner, not assigning anyone new. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-03-26. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Regression Test Proposal
Do we agree 👍 or 👎 |
@anmurali Friendly bump for payment 🙇 |
I think this is a good test to Add to testrail |
@anmurali Accepted, thanks! |
Offer accepted Thanks! |
@anmurali Friendly bump to complete the payment 🙇 |
@anmurali, @jjcoffee, @mountiny, @ishpaul777 Huh... This is 4 days overdue. Who can take care of this? |
Both paid! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Found when validating PR : #37421
Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Expected Result:
All the chats will be displayed since the workspace switcher is Expensify (all chats).
Actual Result:
Only the chats under the deleted workspace are displayed when the workspace switcher is Expensify.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6412960_1710377464684.bandicam_2024-03-14_08-45-35-732.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @anmuraliIssue Owner
Current Issue Owner: @anmuraliThe text was updated successfully, but these errors were encountered: