Android - Not here page shows up after deleting workspace

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Launch New Expensify app.
2. Go to Profile > Workspaces > any workspace.
3. Go to Profile.
4. Tap Delete.
5. Delete the workspace.

Expected Result:

App will redirect to All workspaces page.

Actual Result:

Not here page shows up after deleting workspace.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6413066_1710387122941.Screen_Recording_20240314_113053_New_Expensify.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@pecanoro I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to #wave-collect - Release 1
CC @trjExpensify

[mountiny]

Might be related to the ideal nav PR

[kosmydel]

Hey, I'm from Software Mansion I'm going to investigate it.

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not here page shows up after deleting workspace

What is the root cause of that problem?

When we delete the workspace we call goBackFromInvalidPolicy:

App/src/pages/workspace/WorkspaceProfilePage.tsx

Lines 81 to 89 in 0a512c9

	const confirmDeleteAndHideModal = useCallback(() => {
	if (!policy?.id || !policyName) {
	return;
	}
	Policy.deleteWorkspace(policy?.id, policyName);
	PolicyUtils.goBackFromInvalidPolicy();

Inside of the goBackFromInvalidPolicy util, We use Navigation.goback :

App/src/libs/PolicyUtils.ts

Lines 268 to 269 in 0a512c9

	function goBackFromInvalidPolicy() {
	Navigation.goBack(ROUTES.SETTINGS_WORKSPACES);

On view where we have backButton, this causes regression, this bug doesn't exist on full view of MacOS web :) only on small screens

What changes do you think we should make in order to solve the problem?

Use Navigation.navigate(ROUTES.SETTINGS_WORKSPACES) instead.

What alternative solutions did you explore? (Optional)

N/A

[allgandalf]

@mountiny Not sure if this is going to be external but above proposal works fine :),

Result video:

simplescreenrecorder-2024-03-14_19.39.02.mp4

[mkhutornyi]

Sorry for late. I should have reviewed linked PR.
@jayeshmangwani in the future, please tag C+ who reviewed offending PR and give them priority. Start review only if they're not available soon.

[jayeshmangwani]

Sorry for the confusion @mkhutornyi, I skipped the process and reviewed the PR, next time I will keep in mind to first tag the C+ of the offending PR

[luacmartins]

@pecanoro @jayeshmangwani @kosmydel I can still reproduce this in staging after the CP

Screen.Recording.2024-03-14.at.11.57.30.AM.mov

[luacmartins]

I think this might be related to Ideal Nav v2 @WojtekBoman @mountiny. I'm gonna demote it to NAB since the user is no longer stuck in the not found page, but we need to look into this and prevent the not found page to be shown.

[kosmydel]

I think this might be related to Ideal Nav v2 @WojtekBoman @mountiny. I'm gonna demote it to NAB since the user is no longer stuck in the not found page, but we need to look into this and prevent the not found page to be shown.

Oh, sorry for the inconvenience. I must have missed that there is a short glimpse of that not-found screen. Glad that it at least stopped being a deploy blocker.

I or @WojtekBoman will look at this on Monday because today I'm only at for a while at work and it is no longer a deploy blocker.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: Not here page shows up after deleting workspace #38321

If no regressions arise, payment will be issued on 2024-03-22. 🎊

For reference, here are some details about the assignees on this issue:

• @kosmydel does not require payment (Contractor)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: Not here page shows up after deleting workspace #38321

If no regressions arise, payment will be issued on 2024-03-25. 🎊

For reference, here are some details about the assignees on this issue:

• @kosmydel does not require payment (Contractor)

[WojtekBoman]

@pecanoro @jayeshmangwani @kosmydel I can still reproduce this in staging after the CP

Screen.Recording.2024-03-14.at.11.57.30.AM.mov

Hey! I’m Wojtek from Software Mansion, the expert agency, and I’d like to work on this issue.

[jayeshmangwani]

@bfitzexpensify Automation failed for the issue, This issue is ready for payout.

[bfitzexpensify]

Thanks for the bump @jayeshmangwani - offer sent.

[jayeshmangwani]

Thanks, offer accepted

[bfitzexpensify]

Payment complete, closing this out.