Profile - Switch to Expensify Classic is under Account instead of General

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #37421

Action Performed:

1. NewDot: Login to Account (Web/mWeb/Desktop)
2. Click on 'Profile' at the bottom (user's avatar)

Expected Result:

'Switch to Expensify Classic' option is under General section

Actual Result:

'Switch to Expensify Classic' option is under Account section

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1
CC @trjExpensify

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Switch to Expensify Classic is under Account instead of General

What is the root cause of that problem?

We have kept Switch to Expensify under Accounts section:

App/src/pages/settings/InitialSettingsPage.tsx

Lines 139 to 147 in d4eaf4e

	const defaultMenu: Menu = {
	sectionStyle: styles.accountSettingsSectionContainer,
	sectionTranslationKey: 'initialSettingsPage.account',
	items: [
	{
	translationKey: 'exitSurvey.goToExpensifyClassic',
	icon: Expensicons.ExpensifyLogoNew,
	routeName: ROUTES.SETTINGS_EXIT_SURVEY_REASON,
	},

What changes do you think we should make in order to solve the problem?

Move it to General section over here:

App/src/pages/settings/InitialSettingsPage.tsx

Lines 229 to 234 in d4eaf4e

	const defaultMenu: Menu = {
	sectionStyle: {
	...styles.pt4,
	},
	sectionTranslationKey: 'initialSettingsPage.general',
	items: [

What alternative solutions did you explore? (Optional)

N/A

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Profile - Switch to Expensify Classic is under Account instead of General

What is the root cause of that problem?

The option is in the accountMenuItemsData array.

App/src/pages/settings/InitialSettingsPage.tsx

Lines 142 to 147 in aca0f8c

	items: [
	{
	translationKey: 'exitSurvey.goToExpensifyClassic',
	icon: Expensicons.ExpensifyLogoNew,
	routeName: ROUTES.SETTINGS_EXIT_SURVEY_REASON,
	},

What changes do you think we should make in order to solve the problem?

Move here:

App/src/pages/settings/InitialSettingsPage.tsx

Line 227 in aca0f8c

const generalMenuItemsData: Menu = useMemo(() => {

Result

[trjExpensify]

This is intentional now as part of HybridApp plans, so it's easier for people to find how to switch back. Going to close this out. CC: @AndrewGable @JmillsExpensify for vis