-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile - Switch to Expensify Classic is under Account instead of General #38354
Comments
Triggered auto assignment to @zanyrenney ( |
@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #wave-collect - Release 1 |
ProposalPlease re-state the problem that we are trying to solve in this issue.Switch to Expensify Classic is under Account instead of General What is the root cause of that problem?We have kept Switch to Expensify under Accounts section: App/src/pages/settings/InitialSettingsPage.tsx Lines 139 to 147 in d4eaf4e
What changes do you think we should make in order to solve the problem?Move it to General section over here: App/src/pages/settings/InitialSettingsPage.tsx Lines 229 to 234 in d4eaf4e
What alternative solutions did you explore? (Optional)N/A |
ProposalPlease re-state the problem that we are trying to solve in this issue.Profile - Switch to Expensify Classic is under Account instead of General What is the root cause of that problem?The option is in the App/src/pages/settings/InitialSettingsPage.tsx Lines 142 to 147 in aca0f8c
What changes do you think we should make in order to solve the problem?Move here:
Result |
This is intentional now as part of HybridApp plans, so it's easier for people to find how to switch back. Going to close this out. CC: @AndrewGable @JmillsExpensify for vis |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR #37421
Action Performed:
Expected Result:
'Switch to Expensify Classic' option is under General section
Actual Result:
'Switch to Expensify Classic' option is under Account section
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: