Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User is not navigated to Concierge chat after changing their role to Employee #38580

Closed
6 tasks done
kavimuru opened this issue Mar 19, 2024 · 5 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing #35923
Version Number: 1.4.54-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Pre-condition: User submitted an expense as an employee to a collect workspace and invited another user as an auditor.

  1. In ND, log in as the auditor, go to an expense report submitted by the employee
  2. In OD, log in as the admin, change the role of the auditor to employee
  3. In ND, verify that app does not crash
  4. In OD, as the admin, change the role of the employee to auditor
  5. In ND, go to that workspace's policy expense chat
  6. In OD, as the admin, change the role of the auditor to employee

Expected Result:

User is navigated to Concierge chat

Actual Result:

User is navigated to Concierge chat only after refreshing the page

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6418502_1710803429202.bandicam_2024-03-19_01-03-46-033.mp4

View all open jobs on GitHub

@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 19, 2024
Copy link

melvin-bot bot commented Mar 19, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@kavimuru
Copy link
Author

We think this bug might be related to #wave-collect - Release 1

@kavimuru
Copy link
Author

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@tienifr
Copy link
Contributor

tienifr commented Mar 19, 2024

I implemented #35923 and I could not reproduce this. You have to wait for a moment before Pusher sent the event data. In the attached video, QA immediately refreshed the page after changing role without waiting.

@lschurr
Copy link
Contributor

lschurr commented Mar 19, 2024

Sounds like this isn't reproducible. Going to close.

@lschurr lschurr closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants