Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paid expense - Owner for expense preview and paid system message is displayed incorrectly #38860

Closed
6 tasks done
izarutskaya opened this issue Mar 23, 2024 · 9 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2 Needs Reproduction Reproducible steps needed

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com.
  2. [Member] Go to workspace chat.
  3. [Member] Create two manual requests.
  4. [Admin and member] Go to expense report.
  5. [Admin] Pay elsewhere the report.

Expected Result:

The owner for expense preview and paid system message will be displayed correctly.

Actual Result:

After paying the report, the first expense preview is missing the owner, while the second preview shows the owner.
The system paid message is missing the admin avatar and name too (owner).

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6423715_1711140229250.20240323_043916.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 23, 2024
Copy link

melvin-bot bot commented Mar 23, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 23, 2024
@melvin-bot melvin-bot bot added Daily KSv2 and removed Hourly KSv2 labels Mar 23, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 23, 2024

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@izarutskaya
Copy link
Author

@lschurr I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #collect project.

@izarutskaya
Copy link
Author

Production

Screenshot 2024-03-23 at 04 48 41

@roryabraham roryabraham added Hourly KSv2 and removed Daily KSv2 labels Mar 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 25, 2024
@cead22
Copy link
Contributor

cead22 commented Mar 25, 2024

I couldn't reproduce on dev / main

Admin Requester
image image

@melvin-bot melvin-bot bot removed the Overdue label Mar 25, 2024
@cead22
Copy link
Contributor

cead22 commented Mar 25, 2024

I asked for help with the setup to reproduce this in #expensify-open-source, but @izarutskaya if you can update your repro steps to include setting up the accounts to get the Pay Elsewhere button, that'd be helpful! Thanks

@cead22
Copy link
Contributor

cead22 commented Mar 26, 2024

I couldn't reproduce on staging with the pay elsewhere button. For some reason the expense report chat looks like it's archived from the payer's account, and I'm not sure if that's because I'm using different steps or a different setup, but the UI looks fine

@cead22 cead22 closed this as completed Mar 26, 2024
@cead22 cead22 added DeployBlockerCash This issue or pull request should block deployment Needs Reproduction Reproducible steps needed and removed DeployBlockerCash This issue or pull request should block deployment labels Mar 26, 2024

This comment was marked as duplicate.

@yuwenmemon yuwenmemon removed the DeployBlockerCash This issue or pull request should block deployment label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2 Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

5 participants