-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-04-05] [$250] [Simplified Collect][Distance rates] No pop-over after bulk-selecting rates and trying to disable/delete them #38876
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think that this bug might be related to #wave-collect - Release 1 |
Triggered auto assignment to @arosiclair ( |
I am Michał from Callstack - expert contributor group. I’d like to work on this job. |
Job added to Upwork: https://www.upwork.com/jobs/~01da91acddaa976701 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh ( |
Upwork job price has been updated to $250 |
Assigning Michal and taking over since its related to the |
This issue was happening on all platforms as it was related to JS logic |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-04-05. 🎊 For reference, here are some details about the assignees on this issue:
|
Triggered auto assignment to @sonialiap ( |
$250 to @hoangzinh unless you have reviewed the offending PR too? |
oh nope, the offending PR is not mine. Hehe |
@hoangzinh $250 - offer sent |
Accepted. Thanks @sonialiap |
Payment Summary
BugZero Checklist (@sonialiap)
|
Payment completed ✔️ |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.56.0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #38237
Issue reported by: Applause - Internal Team
Action Performed:
precondition: user created a collect policy in OD
and log in as the admin of the collect policy
Expected Result:
The same pop-over is displayed in step 6 and 9 notifying that at least one distance rate should be enabled
Actual Result:
The error message "There must be at least one enabled distance rate' is displayed instead of the pop-over the second time trying to disable the distance rates, the error on the distance rate edit screen is shown.
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6424007_1711171299608.video_2024-03-23_01-21-21.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @sonialiapThe text was updated successfully, but these errors were encountered: