[Backwards Compatibility] Workspace chat shows skeleton loading when changing report from Invoice to Expense

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.56-1
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #36747
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User is an employee of Collect workspace.

1. Go to staging.new.expensify.com.
2. Go to workspace chat.
3. Create a manual request.
4. While leaving workspace chat open, change the report from expense to invoice on Old Dot.
5. Change the report back to expense.

Expected Result:

The workspace chat will update the expense accordingly.

Actual Result:

The workspace chat shows skeleton loading when changing the report from invoice to expense.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6424351_1711207663092.bandicam_2024-03-23_23-17-02-865.1.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[yuwenmemon]

The issue is actually converting from Invoice to Expense, which is not a supported flow just yet, but probably should be an issue we look into as a part of Wave Collect cc @trjExpensify

[trjExpensify]

Yeah, I agree. On OldDot, I'm pretty sure we restrict invoice creation to admins, but nevertheless, we should make sure changing the report type from invoice to expense works okay. Is this not on the "Backwards compatibility" radar already, @puneetlath?

In the meantime, I'll put it in polish to make sure we don't lose it.

[tylerkaraszewski]

What should I do with this issue in the meantime?

[trjExpensify]

I think we can fix it, if it's not being worked on somewhere else! Bumped Puneet on the above.

[puneetlath]

raised it here: https://expensify.slack.com/archives/C036QM0SLJK/p1712246437566919?thread_ts=1712061967.333289&cid=C036QM0SLJK

[puneetlath]

As discussed in the thread, this isn't covered elsewhere, so we should fix it in this issue.

[melvin-bot]

@tylerkaraszewski Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@tylerkaraszewski 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@tylerkaraszewski 10 days overdue. I'm getting more depressed than Marvin.

[tylerkaraszewski]

I will fix this soon-ish.

[tylerkaraszewski]

Looking at this next.

[melvin-bot]

@tylerkaraszewski Whoops! This issue is 2 days overdue. Let's get this updated quick!

[tylerkaraszewski]

Ok, actually looking at this next.

[melvin-bot]

@tylerkaraszewski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[tylerkaraszewski]

I've got a newsletter to prep that's a higher priority than this.

[melvin-bot]

@tylerkaraszewski Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@tylerkaraszewski Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@tylerkaraszewski 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

@tylerkaraszewski 10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

@tylerkaraszewski 12 days overdue. Walking. Toward. The. Light...

[melvin-bot]

This issue has not been updated in over 14 days. @tylerkaraszewski eroding to Weekly issue.

[melvin-bot]

This issue has not been updated in over 15 days. @tylerkaraszewski eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!